Clean up some copy/paste in a test.

Clean up some copy/paste in a test.

Almost all of these tests had the same few steps, so I pulled that out
into a helper function and used that.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/528f6c01a7b1a875f3e8cd972092d841b3d438b2

[Bob Nystrom, 2016-03-09 01:25:14]

rnystrom@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-03-09 01:37:38]

LGTM

https://codereview.chromium.org/1780623002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/static_type_warning_code_test.dart (right):

https://codereview.chromium.org/1780623002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/static_type_warning_code_test.dart:26: //
TODO(rnystrom): This doesn't look right.
Note that the method's name is "fail", indicating that the test is expected to
fail. What this likely means is that someone wrote the skeleton of a test for
the INACCESSIBLE_SETTER warning, but forgot to come back and write test code for
it.

[Bob Nystrom, 2016-03-09 01:40:49]

Description was changed from

==========
Clean up some copy/paste in a test.

Almost all of these tests had the same few steps, so I pulled that out
into a helper function and used that.
==========

to

==========
Clean up some copy/paste in a test.

Almost all of these tests had the same few steps, so I pulled that out
into a helper function and used that.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/528f6c01a7b1a875f3e8cd972092d841b3d438b2
==========

[Bob Nystrom, 2016-03-09 01:40:50]

Committed patchset #1 (id:1) manually as
528f6c01a7b1a875f3e8cd972092d841b3d438b2 (presubmit successful).

[Bob Nystrom, 2016-03-09 01:46:47]

https://codereview.chromium.org/1780623002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/static_type_warning_code_test.dart (right):

https://codereview.chromium.org/1780623002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/static_type_warning_code_test.dart:26: //
TODO(rnystrom): This doesn't look right.
On 2016/03/09 01:37:38, Brian Wilkerson wrote:
> Note that the method's name is "fail", indicating that the test is expected to
> fail. What this likely means is that someone wrote the skeleton of a test for
> the INACCESSIBLE_SETTER warning, but forgot to come back and write test code
for
> it.

That's what I figured. :) Tests that are just expected to fail in some blanket
way tend to be brittle to code rot in that way.