Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.h

Issue 1780603002: blink: Rename bindings/ methods to prefix with get when they collide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clash-bindings: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
index 0b45e5831be30ce7bb19463a746d49fa1cb1f46b..46bd284a93ffecd896ef88ca23d472d1f655f835 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
@@ -170,7 +170,7 @@ inline void v8SetReturnValueString(const CallbackInfo& info, const String& strin
v8SetReturnValueEmptyString(info);
return;
}
- V8PerIsolateData::from(isolate)->stringCache()->setReturnValueFromString(info.GetReturnValue(), string.impl());
+ V8PerIsolateData::from(isolate)->getStringCache()->setReturnValueFromString(info.GetReturnValue(), string.impl());
}
template<typename CallbackInfo>
@@ -180,7 +180,7 @@ inline void v8SetReturnValueStringOrNull(const CallbackInfo& info, const String&
v8SetReturnValueNull(info);
return;
}
- V8PerIsolateData::from(isolate)->stringCache()->setReturnValueFromString(info.GetReturnValue(), string.impl());
+ V8PerIsolateData::from(isolate)->getStringCache()->setReturnValueFromString(info.GetReturnValue(), string.impl());
}
template<typename CallbackInfo>
@@ -420,14 +420,14 @@ inline v8::Local<v8::String> v8String(v8::Isolate* isolate, const String& string
{
if (string.isNull())
return v8::String::Empty(isolate);
- return V8PerIsolateData::from(isolate)->stringCache()->v8ExternalString(isolate, string.impl());
+ return V8PerIsolateData::from(isolate)->getStringCache()->v8ExternalString(isolate, string.impl());
}
inline v8::Local<v8::String> v8String(v8::Isolate* isolate, const CompressibleString& string)
{
if (string.isNull())
return v8::String::Empty(isolate);
- return V8PerIsolateData::from(isolate)->stringCache()->v8ExternalString(isolate, string);
+ return V8PerIsolateData::from(isolate)->getStringCache()->v8ExternalString(isolate, string);
}
inline v8::Local<v8::String> v8AtomicString(v8::Isolate* isolate, const char* str, int length = -1)

Powered by Google App Engine
This is Rietveld 408576698