Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1780553002: Fix Starting the feedback app. (Closed)

Created:
4 years, 9 months ago by afakhry
Modified:
4 years, 9 months ago
Reviewers:
rkc, oshima
CC:
chromium-reviews, kalyank, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Starting the feedback app. The accelerator for starting the feedback app should be non-repeatable. We should only request system information once the UI is shown not before, and limit doing the initialization only to when we determine we need to create a new feedback window. R=rkc@chromium.org BUG=590892 TEST=manually Committed: https://crrev.com/1eeae89ed794769fba4fe6b53e3d3250ca20d261 Cr-Commit-Position: refs/heads/master@{#380230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -27 lines) Patch
M ash/accelerators/accelerator_table.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/feedback/js/event_handler.js View 3 chunks +17 lines, -18 lines 0 comments Download
M chrome/browser/resources/feedback/js/feedback.js View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
afakhry
Rahul, could you please review.
4 years, 9 months ago (2016-03-08 23:00:05 UTC) #1
afakhry
oshima@chromium.org for accelerator_table.cc
4 years, 9 months ago (2016-03-09 00:53:59 UTC) #3
oshima
ash lgtm
4 years, 9 months ago (2016-03-09 02:26:10 UTC) #4
rkc
lgtm
4 years, 9 months ago (2016-03-09 20:49:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780553002/1
4 years, 9 months ago (2016-03-09 20:56:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 21:44:04 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 21:45:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1eeae89ed794769fba4fe6b53e3d3250ca20d261
Cr-Commit-Position: refs/heads/master@{#380230}

Powered by Google App Engine
This is Rietveld 408576698