Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: webkit/glue/webdevtoolsagent_impl.cc

Issue 178053: DevTools: Close inspector controller on detach; hide node highlight on detach... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/glue/devtools/js/inspector_controller_impl.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "Document.h" 9 #include "Document.h"
10 #include "EventListener.h" 10 #include "EventListener.h"
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 UnhideResourcesPanelIfNecessary(); 94 UnhideResourcesPanelIfNecessary();
95 // Allow controller to send messages to the frontend. 95 // Allow controller to send messages to the frontend.
96 InspectorController* ic = web_view_impl_->page()->inspectorController(); 96 InspectorController* ic = web_view_impl_->page()->inspectorController();
97 ic->setWindowVisible(true, false); 97 ic->setWindowVisible(true, false);
98 attached_ = true; 98 attached_ = true;
99 } 99 }
100 100
101 void WebDevToolsAgentImpl::Detach() { 101 void WebDevToolsAgentImpl::Detach() {
102 // Prevent controller from sending messages to the frontend. 102 // Prevent controller from sending messages to the frontend.
103 InspectorController* ic = web_view_impl_->page()->inspectorController(); 103 InspectorController* ic = web_view_impl_->page()->inspectorController();
104 ic->setWindowVisible(false, false); 104 ic->hideHighlight();
105 ic->close();
105 DisposeUtilityContext(); 106 DisposeUtilityContext();
106 inspector_frontend_script_state_.clear(); 107 inspector_frontend_script_state_.clear();
107 devtools_agent_host_.set(NULL); 108 devtools_agent_host_.set(NULL);
108 debugger_agent_impl_.set(NULL); 109 debugger_agent_impl_.set(NULL);
109 attached_ = false; 110 attached_ = false;
110 } 111 }
111 112
112 void WebDevToolsAgentImpl::OnNavigate() { 113 void WebDevToolsAgentImpl::OnNavigate() {
113 DebuggerAgentManager::OnNavigate(); 114 DebuggerAgentManager::OnNavigate();
114 } 115 }
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 const std::string& command, 273 const std::string& command,
273 int caller_id) { 274 int caller_id) {
274 DebuggerAgentManager::ExecuteDebuggerCommand(command, caller_id); 275 DebuggerAgentManager::ExecuteDebuggerCommand(command, caller_id);
275 } 276 }
276 277
277 // static 278 // static
278 void WebDevToolsAgent::SetMessageLoopDispatchHandler( 279 void WebDevToolsAgent::SetMessageLoopDispatchHandler(
279 MessageLoopDispatchHandler handler) { 280 MessageLoopDispatchHandler handler) {
280 DebuggerAgentManager::SetMessageLoopDispatchHandler(handler); 281 DebuggerAgentManager::SetMessageLoopDispatchHandler(handler);
281 } 282 }
OLDNEW
« no previous file with comments | « webkit/glue/devtools/js/inspector_controller_impl.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698