Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 178053: DevTools: Close inspector controller on detach; hide node highlight on detach... (Closed)

Created:
11 years, 3 months ago by pfeldman
Modified:
9 years, 7 months ago
Reviewers:
yurys
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

DevTools: Close inspector controller on detach; hide node highlight on detach; mitigate new callframe migration in WebKit. BUG=20554 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25023

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M webkit/glue/devtools/js/debugger_agent.js View 1 1 chunk +0 lines, -8 lines 0 comments Download
M webkit/glue/devtools/js/inspector_controller_impl.js View 2 chunks +1 line, -8 lines 0 comments Download
M webkit/glue/webdevtoolsagent_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
pfeldman
11 years, 3 months ago (2009-09-01 08:32:05 UTC) #1
yurys
11 years, 3 months ago (2009-09-01 08:39:28 UTC) #2
On 2009/09/01 08:32:05, pfeldman wrote:
> 

LGTM

Powered by Google App Engine
This is Rietveld 408576698