Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1780523006: Add tests for input.ime.* APIs. (Closed)

Created:
4 years, 9 months ago by Azure Wei
Modified:
4 years, 9 months ago
Reviewers:
Shu Chen
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, tfarina, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for input.ime.* APIs. Make chromeos::MockIMEInputContextHandler as ui::MockIMEInputContextHandler used for all platforms. Add tests for input.ime.onFocus/onBlur/onCompositionBoundsChanged/setComposition/commitText. BUG=517773 TEST=browser_test --gtest_filter=InputImeApiTest.* Committed: https://crrev.com/e28639662994ed0f2dd9470e95feceaa421e3d70 Cr-Commit-Position: refs/heads/master@{#381437}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -8 lines) Patch
M chrome/browser/ui/views/ime/input_ime_apitest_nonchromeos.cc View 1 2 3 chunks +38 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js View 1 2 3 chunks +63 lines, -2 lines 1 comment Download
M ui/base/ime/dummy_text_input_client.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M ui/base/ime/dummy_text_input_client.cc View 1 2 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
Azure Wei
Hi Shu, can you please review this cl? Thank you!
4 years, 9 months ago (2016-03-10 07:32:30 UTC) #3
Shu Chen
https://codereview.chromium.org/1780523006/diff/20001/chrome/browser/ui/views/ime/input_ime_apitest_nonchromeos.cc File chrome/browser/ui/views/ime/input_ime_apitest_nonchromeos.cc (right): https://codereview.chromium.org/1780523006/diff/20001/chrome/browser/ui/views/ime/input_ime_apitest_nonchromeos.cc#newcode55 chrome/browser/ui/views/ime/input_ime_apitest_nonchromeos.cc:55: IN_PROC_BROWSER_TEST_F(InputImeApiTest, FocusBlurTest) { Please combine all the tests as ...
4 years, 9 months ago (2016-03-11 01:47:26 UTC) #4
Azure Wei
https://codereview.chromium.org/1780523006/diff/20001/chrome/browser/ui/views/ime/input_ime_apitest_nonchromeos.cc File chrome/browser/ui/views/ime/input_ime_apitest_nonchromeos.cc (right): https://codereview.chromium.org/1780523006/diff/20001/chrome/browser/ui/views/ime/input_ime_apitest_nonchromeos.cc#newcode55 chrome/browser/ui/views/ime/input_ime_apitest_nonchromeos.cc:55: IN_PROC_BROWSER_TEST_F(InputImeApiTest, FocusBlurTest) { On 2016/03/11 01:47:25, Shu Chen wrote: ...
4 years, 9 months ago (2016-03-16 03:07:24 UTC) #5
Shu Chen
https://codereview.chromium.org/1780523006/diff/40001/chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js File chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js (right): https://codereview.chromium.org/1780523006/diff/40001/chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js#newcode132 chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js:132: chrome.test.succeed(); remove this line.
4 years, 9 months ago (2016-03-16 05:55:39 UTC) #6
Shu Chen
lgtm
4 years, 9 months ago (2016-03-16 08:43:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780523006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780523006/40001
4 years, 9 months ago (2016-03-16 08:44:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/195950)
4 years, 9 months ago (2016-03-16 10:03:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780523006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780523006/40001
4 years, 9 months ago (2016-03-16 10:04:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780523006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780523006/40001
4 years, 9 months ago (2016-03-16 12:07:32 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-16 12:12:30 UTC) #18
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/e28639662994ed0f2dd9470e95feceaa421e3d70 Cr-Commit-Position: refs/heads/master@{#381437}
4 years, 9 months ago (2016-03-16 12:13:35 UTC) #20
Nico
4 years, 9 months ago (2016-03-16 17:05:26 UTC) #21
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1805423002/ by thakis@chromium.org.

The reason for reverting is: Tests don't reliably pass, see
http://crbug.com/595355.

Powered by Google App Engine
This is Rietveld 408576698