Rename platform/fonts/CharacterData.h to avoid conflict with core/dom

Rename platform/fonts/CharacterData.h to avoid conflict with core/dom

BUG=592780
Committed: https://crrev.com/e373cd743be884678f12e136800802d12603d953
Cr-Commit-Position: refs/heads/master@{#380362}

[kojii, 2016-03-09 07:46:11]

Description was changed from

==========
character-data-rename

BUG=592780
==========

to

==========
Rename platform/fonts/CharacterData.h to avoid conflict with dom

BUG=592780
==========

[kojii, 2016-03-09 07:46:31]

Description was changed from

==========
Rename platform/fonts/CharacterData.h to avoid conflict with dom

BUG=592780
==========

to

==========
Rename platform/fonts/CharacterData.h to avoid conflict with core/dom

BUG=592780
==========

[kojii, 2016-03-09 13:05:56]

kojii@chromium.org changed reviewers:
+ tkent@chromium.org

[kojii, 2016-03-09 13:05:56]

PTAL.

[tkent, 2016-03-09 23:30:32]

https://codereview.chromium.org/1780523003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/Character.cpp (right):

https://codereview.chromium.org/1780523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/Character.cpp:40: #include
"CharacterPropertyDataGenerator.h"
should be "platform/fonts/CharacterPropertyDataGenerator.h"

https://codereview.chromium.org/1780523003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/CharacterPropertyDataGenerator.cpp
(right):

https://codereview.chromium.org/1780523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/CharacterPropertyDataGenerator.cpp:5:
#include "CharacterPropertyDataGenerator.h"
should be "platform/fonts/CharacterPropertyDataGenerator.h"

https://codereview.chromium.org/1780523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/CharacterPropertyDataGenerator.cpp:7:
#include "CharacterProperty.h"
should be "platform/fonts/CharacterProperty.h"

[kojii, 2016-03-10 05:04:50]

PTAL.

Linux failure doesn't seem to be related.

https://codereview.chromium.org/1780523003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/Character.cpp (right):

https://codereview.chromium.org/1780523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/Character.cpp:40: #include
"CharacterPropertyDataGenerator.h"
On 2016/03/09 at 23:30:32, tkent wrote:
> should be "platform/fonts/CharacterPropertyDataGenerator.h"

Done.

https://codereview.chromium.org/1780523003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/CharacterPropertyDataGenerator.cpp
(right):

https://codereview.chromium.org/1780523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/CharacterPropertyDataGenerator.cpp:5:
#include "CharacterPropertyDataGenerator.h"
On 2016/03/09 at 23:30:32, tkent wrote:
> should be "platform/fonts/CharacterPropertyDataGenerator.h"

Tried in PS3, but this source is compiled with host_tool_chain configuration,
and it fails to find if with "platform/fonts/" so reverted in PS4. I suppose I
can do something in GYP/GN to fix it, but don't know how atm.

https://codereview.chromium.org/1780523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/CharacterPropertyDataGenerator.cpp:7:
#include "CharacterProperty.h"
On 2016/03/09 at 23:30:32, tkent wrote:
> should be "platform/fonts/CharacterProperty.h"

ditto.

[tkent, 2016-03-10 05:13:40]

lgtm

https://codereview.chromium.org/1780523003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/CharacterPropertyDataGenerator.cpp
(right):

https://codereview.chromium.org/1780523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/CharacterPropertyDataGenerator.cpp:5:
#include "CharacterPropertyDataGenerator.h"
On 2016/03/10 at 05:04:49, kojii wrote:
> On 2016/03/09 at 23:30:32, tkent wrote:
> > should be "platform/fonts/CharacterPropertyDataGenerator.h"
> 
> Tried in PS3, but this source is compiled with host_tool_chain configuration,
and it fails to find if with "platform/fonts/" so reverted in PS4. I suppose I
can do something in GYP/GN to fix it, but don't know how atm.

ok.  Please add a TOOD() comment about it.

[kojii, 2016-03-10 05:19:38]

Thank you for the prompt review.

On 2016/03/10 at 05:13:40, tkent wrote:
> 
> ok.  Please add a TOOD() comment about it.

Done in PS5.

[kojii, 2016-03-10 06:28:06]

The CQ bit was checked by kojii@chromium.org

[kojii, 2016-03-10 06:28:07]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1780523003/#ps80001
(title: "Add TODO comment")

[commit-bot: I haz the power, 2016-03-10 06:28:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780523003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780523003/80001

[commit-bot: I haz the power, 2016-03-10 06:33:49]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-10 06:35:52]

Description was changed from

==========
Rename platform/fonts/CharacterData.h to avoid conflict with core/dom

BUG=592780
==========

to

==========
Rename platform/fonts/CharacterData.h to avoid conflict with core/dom

BUG=592780

Committed: https://crrev.com/e373cd743be884678f12e136800802d12603d953
Cr-Commit-Position: refs/heads/master@{#380362}
==========

[commit-bot: I haz the power, 2016-03-10 06:35:53]

Patchset 5 (id:??) landed as
https://crrev.com/e373cd743be884678f12e136800802d12603d953
Cr-Commit-Position: refs/heads/master@{#380362}