Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1780503002: Split off CPDF_Document into its own .cpp/.h files. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Too many blank lines #

Patch Set 3 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -477 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
A core/include/fpdfapi/cpdf_document.h View 1 1 chunk +124 lines, -0 lines 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 2 chunks +1 line, -126 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A + core/src/fpdfapi/fpdf_parser/cpdf_document.cpp View 1 2 2 chunks +13 lines, -1 line 0 comments Download
D core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp View 1 chunk +0 lines, -338 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_cache.cpp View 2 chunks +1 line, -8 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfdoc/doc_action.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfdoc/doc_annot.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfdoc/doc_ap.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfdoc/doc_basic.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfdoc/doc_bookmark.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfdoc/doc_formcontrol.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfdoc/doc_formfield.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfdoc/doc_metadata.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfdoc/doc_ocg.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfdoc/doc_tagged.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfdoc/doc_utils.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfdoc/doc_viewerPreferences.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_IFormFiller.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdf_dataavail.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdf_ext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdfdoc.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdfdoc_unittest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdfsave.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_page.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fsdk_annothandler.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fsdk_baseannot.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_FontMap.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M pdfium.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M xfa/src/fxfa/app/xfa_ffdoc.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/src/fxfa/app/xfa_fontmgr.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
A larger patch to make Dan happy.
4 years, 9 months ago (2016-03-08 20:51:21 UTC) #2
dsinclair
lgtm https://codereview.chromium.org/1780503002/diff/1/core/src/fpdfapi/fpdf_parser/cpdf_document.cpp File core/src/fpdfapi/fpdf_parser/cpdf_document.cpp (right): https://codereview.chromium.org/1780503002/diff/1/core/src/fpdfapi/fpdf_parser/cpdf_document.cpp#newcode344 core/src/fpdfapi/fpdf_parser/cpdf_document.cpp:344: if (m_pDocRender) { if (!m_pDocReader) return; ? https://codereview.chromium.org/1780503002/diff/1/core/src/fpdfapi/fpdf_parser/cpdf_document.cpp#newcode348 ...
4 years, 9 months ago (2016-03-08 20:57:08 UTC) #3
Tom Sepez
https://codereview.chromium.org/1780503002/diff/1/core/src/fpdfapi/fpdf_parser/cpdf_document.cpp File core/src/fpdfapi/fpdf_parser/cpdf_document.cpp (right): https://codereview.chromium.org/1780503002/diff/1/core/src/fpdfapi/fpdf_parser/cpdf_document.cpp#newcode344 core/src/fpdfapi/fpdf_parser/cpdf_document.cpp:344: if (m_pDocRender) { On 2016/03/08 20:57:08, dsinclair wrote: > ...
4 years, 9 months ago (2016-03-08 21:10:31 UTC) #4
Tom Sepez
4 years, 9 months ago (2016-03-08 21:11:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
310438fb97a2363bd0901401ad2506febd64361b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698