Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1780483002: [wasm] Support a two-level namespace for imports. (Closed)

Created:
4 years, 9 months ago by titzer
Modified:
4 years, 9 months ago
Reviewers:
Derek Schuff, binji
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Support a two-level namespace for imports. R=binji@chromium.org,dschuff@chromium.org BUG= Committed: https://crrev.com/d61a0c5a4a6b3e8362b8ebdb2988757a8f692773 Cr-Commit-Position: refs/heads/master@{#34600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -38 lines) Patch
M src/compiler/wasm-compiler.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/wasm/module-decoder.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.cc View 3 chunks +66 lines, -28 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-js.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/test-wasm-module-builder.js View 1 chunk +13 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 2 chunks +15 lines, -5 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 9 months ago (2016-03-08 19:34:59 UTC) #1
binji
lgtm
4 years, 9 months ago (2016-03-08 19:43:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780483002/1
4 years, 9 months ago (2016-03-08 19:46:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 19:55:42 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 19:57:14 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d61a0c5a4a6b3e8362b8ebdb2988757a8f692773
Cr-Commit-Position: refs/heads/master@{#34600}

Powered by Google App Engine
This is Rietveld 408576698