Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1780463008: SkPDF: metadata first (Closed)

Created:
4 years, 9 months ago by hal.canary
Modified:
4 years, 9 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: metadata first Motivation: while experimenting with serializing images immediately, I would like to keep serializing metadata first. TBR=djsollen@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1780463008 Committed: https://skia.googlesource.com/skia/+/2c9c469cc91716c3b3637562b62b549016a9967f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -24 lines) Patch
M site/user/sample/pdf.md View 2 chunks +15 lines, -17 lines 0 comments Download
M tests/PDFMetadataAttributeTest.cpp View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780463008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780463008/1
4 years, 9 months ago (2016-03-10 21:54:17 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-10 22:05:17 UTC) #7
hal.canary
ptal
4 years, 9 months ago (2016-03-11 15:38:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780463008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780463008/1
4 years, 9 months ago (2016-03-20 13:58:00 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-20 14:07:16 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2c9c469cc91716c3b3637562b62b549016a9967f

Powered by Google App Engine
This is Rietveld 408576698