Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1780463006: Roll ANGLE b5abec3..bd38271 (Closed)

Created:
4 years, 9 months ago by Jamie Madill
Modified:
4 years, 6 months ago
Reviewers:
Geoff Lang, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll ANGLE b5abec3..bd38271 https://chromium.googlesource.com/angle/angle.git/+log/b5abec3..bd38271 BUG=593541 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel Committed: https://crrev.com/4146624afda978a7f78e81eac9ac613d488f4827 Cr-Commit-Position: refs/heads/master@{#380414}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780463006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780463006/1
4 years, 9 months ago (2016-03-10 14:51:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 15:44:08 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4146624afda978a7f78e81eac9ac613d488f4827 Cr-Commit-Position: refs/heads/master@{#380414}
4 years, 9 months ago (2016-03-10 15:45:24 UTC) #5
Jamie Madill
Do not revert this roll to fix Clang.. will roll again.
4 years, 9 months ago (2016-03-10 16:28:19 UTC) #6
Nico
4 years, 9 months ago (2016-03-10 18:43:41 UTC) #8
Message was sent while issue was closed.
https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%28dbg%29/builds...


In file included from
..\..\third_party\angle\src\libANGLE\renderer\d3d\d3d11\VertexArray11.cpp:10:
..\..\third_party\angle\src\libANGLE/renderer/d3d/d3d11/VertexArray11.h(38,17) :
 error: private field 'mRenderer' is not used [-Werror,-Wunused-private-field]
    Renderer11 *mRenderer;
               

Please fix quickly or revert. Thanks!

Powered by Google App Engine
This is Rietveld 408576698