PNaCl: ExpandTls: Simplify by using a C++11 lambda function

PNaCl: ExpandTls: Simplify by using a C++11 lambda function

Now that we can use C++11 lambdas, we can define addVarToTlsTemplate()
as a local function rather than using a class (PassState).

Since padToAlignment() only had one call site now, we can inline it
into addVarToTlsTemplate().

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
TEST=test/Transforms/NaCl/expand-tls*.ll
R=smklein@chromium.org

Committed: https://chromium.googlesource.com/native_client/pnacl-llvm/+/82bce97f9aba25c29d5a33773fb9945d6ff7c3de

[Mark Seaborn, 2016-03-10 16:36:31]

mseaborn@chromium.org changed reviewers:
+ smklein@chromium.org

[Sean Klein, 2016-03-10 17:20:42]

lgtm

[Mark Seaborn, 2016-03-11 07:30:07]

Description was changed from

==========
PNaCl: ExpandTls: Simplify by using a C++11 lambda function

Now that we can use C++11 lambdas, we can define addVarToTlsTemplate()
as a local function rather than using a class (PassState).

Since padToAlignment() only had one call site now, we can inline it
into addVarToTlsTemplate().

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
TEST=test/Transforms/NaCl/expand-tls*.ll
==========

to

==========
PNaCl: ExpandTls: Simplify by using a C++11 lambda function

Now that we can use C++11 lambdas, we can define addVarToTlsTemplate()
as a local function rather than using a class (PassState).

Since padToAlignment() only had one call site now, we can inline it
into addVarToTlsTemplate().

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4351
TEST=test/Transforms/NaCl/expand-tls*.ll
R=smklein@chromium.org

Committed:
https://chromium.googlesource.com/native_client/pnacl-llvm/+/82bce97f9aba25c2...
==========

[Mark Seaborn, 2016-03-11 07:30:09]

Committed patchset #2 (id:20001) manually as
82bce97f9aba25c29d5a33773fb9945d6ff7c3de (presubmit successful).