Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1780463003: Revert of nanobench: turn on f16 and sRGB on the bots (Closed)

Created:
4 years, 9 months ago by mtklein
Modified:
4 years, 9 months ago
Reviewers:
mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of nanobench: turn on f16 and sRGB on the bots (patchset #1 id:1 of https://codereview.chromium.org/1769163006/ ) Reason for revert: Debug bots failing at Running writepix_RGBA_UPM f16 ../../../src/core/SkBitmap.cpp:558: fatal error: ""false && \"Can't return addr for config\""" Original issue's description: > nanobench: turn on f16 and sRGB on the bots > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1769163006 > > Committed: https://skia.googlesource.com/skia/+/6b5c5cc7b7bdffb4882706b915b544aba8714961 TBR=reed@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c48fc9b1fdd0ba255a3ef1a9b3bcba9ee918b1f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M tools/nanobench_flags.json View 8 chunks +0 lines, -16 lines 0 comments Download
M tools/nanobench_flags.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of nanobench: turn on f16 and sRGB on the bots
4 years, 9 months ago (2016-03-08 21:25:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780463003/1
4 years, 9 months ago (2016-03-08 21:25:38 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 21:25:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c48fc9b1fdd0ba255a3ef1a9b3bcba9ee918b1f7

Powered by Google App Engine
This is Rietveld 408576698