Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1555)

Unified Diff: third_party/WebKit/Tools/PRESUBMIT.py

Issue 1780453002: [PerfTry] Make it possible to ./run_benchmark try within tools/perf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/run-perf-test.cfg » ('j') | tools/perf/core/trybot_command.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/PRESUBMIT.py
diff --git a/third_party/WebKit/Tools/PRESUBMIT.py b/third_party/WebKit/Tools/PRESUBMIT.py
deleted file mode 100644
index 657061f8cc2c24da40e844b1d8ff7de12d783a74..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Tools/PRESUBMIT.py
+++ /dev/null
@@ -1,54 +0,0 @@
-# Copyright (c) 2013 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-"""Top-level presubmit script for bisect/perf trybot.
-
-See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
-details on the presubmit API built into gcl.
-"""
-
-import imp
-import os
-
-
-def _ExamineConfigFiles(input_api):
- for f in input_api.AffectedFiles():
- if (not f.LocalPath().endswith('run-perf-test.cfg')):
- continue
-
- try:
- cfg_file = imp.load_source('config', os.path.basename(f.LocalPath()))
-
- for k, v in cfg_file.config.iteritems():
- if v:
- return f.LocalPath()
- except (IOError, AttributeError, TypeError):
- return f.LocalPath()
-
- return None
-
-
-def _CheckNoChangesToBisectConfigFile(input_api, output_api):
- results = _ExamineConfigFiles(input_api)
- if results:
- return [output_api.PresubmitError(
- 'The perf try config file should only contain a config dict with '
- 'empty fields. Changes to this file should never be submitted.',
- items=[results])]
-
- return []
-
-
-def CommonChecks(input_api, output_api):
- results = []
- results.extend(_CheckNoChangesToBisectConfigFile(input_api, output_api))
- return results
-
-
-def CheckChangeOnUpload(input_api, output_api):
- return CommonChecks(input_api, output_api)
-
-
-def CheckChangeOnCommit(input_api, output_api):
- return CommonChecks(input_api, output_api)
« no previous file with comments | « no previous file | third_party/WebKit/Tools/run-perf-test.cfg » ('j') | tools/perf/core/trybot_command.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698