AudioManagerBase: Create and run the audio thread lazily.

AudioManagerBase: Create and run the audio thread lazily.

This allows AudioManagerBase subclasses not have to create an
unnecessary thread if they want to use a different audio task runner.

BUG=594234
Committed: https://crrev.com/f4945022d19aaa9a0c70346398f1b2b9e4d64899
Cr-Commit-Position: refs/heads/master@{#381282}

[alokp, 2016-03-12 07:53:36]

alokp@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[alokp, 2016-03-12 07:53:36]

I think it would be more robust to pass the audio/worker task runners to
AudioManager constructor and make AudioMananger::Get[Worker]TaskRunner
non-virtual. But this minimal patch should work too.

[DaleCurtis, 2016-03-14 21:46:09]

This looks pretty good since it moves some platform specific code out of the
base manager.

https://codereview.chromium.org/1780333007/diff/1/media/audio/mac/audio_manag...
File media/audio/mac/audio_manager_mac.cc (right):

https://codereview.chromium.org/1780333007/diff/1/media/audio/mac/audio_manag...
media/audio/mac/audio_manager_mac.cc:548:
DCHECK(task_runner_->BelongsToCurrentThread());
Why this change? Seems better to use the GetTaskRunner() like you did in am_base

[alokp, 2016-03-14 22:07:17]

https://codereview.chromium.org/1780333007/diff/1/media/audio/mac/audio_manag...
File media/audio/mac/audio_manager_mac.cc (right):

https://codereview.chromium.org/1780333007/diff/1/media/audio/mac/audio_manag...
media/audio/mac/audio_manager_mac.cc:548:
DCHECK(task_runner_->BelongsToCurrentThread());
On 2016/03/14 21:46:09, DaleCurtis wrote:
> Why this change? Seems better to use the GetTaskRunner() like you did in
am_base

reverted in the new patch.

[DaleCurtis, 2016-03-14 22:08:26]

lgtm

[alokp, 2016-03-14 23:12:22]

The CQ bit was checked by alokp@chromium.org

[alokp, 2016-03-14 23:12:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1780333007/#ps40001
(title: "fixed unittests")

[commit-bot: I haz the power, 2016-03-14 23:12:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780333007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780333007/40001

[commit-bot: I haz the power, 2016-03-14 23:33:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-14 23:33:10]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alokp, 2016-03-14 23:37:35]

Dale: I remembered why I had changed GetTaskRunner() to task_runner_:

../../media/audio/mac/audio_manager_mac.cc:838:10: error: member function
'GetTaskRunner' not viable: 'this' argument has type 'const
media::AudioManagerMac', but function is not marked const
  DCHECK(GetTaskRunner()->BelongsToCurrentThread());

I could either use task_runner_ directly or make GetTaskRunner() const again by
marking audio_thread_ mutable.

I prefer the first option because it makes GetTaskRunner consistent with
GetWorkerTaskRunner. Please let me know what you prefer.

[DaleCurtis, 2016-03-15 03:07:04]

back to task_runner_ sgtm

[alokp, 2016-03-15 04:44:45]

The CQ bit was checked by alokp@chromium.org

[alokp, 2016-03-15 04:44:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1780333007/#ps60001
(title: "fixed compile error on mac")

[commit-bot: I haz the power, 2016-03-15 04:44:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780333007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780333007/60001

[commit-bot: I haz the power, 2016-03-15 05:38:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-15 05:38:44]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alokp, 2016-03-15 17:44:02]

The CQ bit was checked by alokp@chromium.org

[alokp, 2016-03-15 17:44:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1780333007/#ps80001
(title: "fixed media unittests on mac")

[commit-bot: I haz the power, 2016-03-15 17:44:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780333007/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780333007/80001

[commit-bot: I haz the power, 2016-03-15 19:34:28]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-15 19:35:58]

Description was changed from

==========
AudioManagerBase: Create and run the audio thread lazily.

This allows AudioManagerBase subclasses not have to create an
unnecessary thread if they want to use a different audio task runner.

BUG=594234
==========

to

==========
AudioManagerBase: Create and run the audio thread lazily.

This allows AudioManagerBase subclasses not have to create an
unnecessary thread if they want to use a different audio task runner.

BUG=594234

Committed: https://crrev.com/f4945022d19aaa9a0c70346398f1b2b9e4d64899
Cr-Commit-Position: refs/heads/master@{#381282}
==========

[commit-bot: I haz the power, 2016-03-15 19:35:59]

Patchset 5 (id:??) landed as
https://crrev.com/f4945022d19aaa9a0c70346398f1b2b9e4d64899
Cr-Commit-Position: refs/heads/master@{#381282}