Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Side by Side Diff: src/compiler/x64/code-generator-x64.cc

Issue 1780193003: [turbofan] Byte and word memory operands in x64 cmp/test. Fixes arithmetic_op_8 in assembler-x64.cc (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixes cmpb. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/code-stub-assembler.cc ('k') | src/compiler/x64/instruction-codes-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/compiler/code-generator-impl.h" 8 #include "src/compiler/code-generator-impl.h"
9 #include "src/compiler/gap-resolver.h" 9 #include "src/compiler/gap-resolver.h"
10 #include "src/compiler/node-matchers.h" 10 #include "src/compiler/node-matchers.h"
(...skipping 821 matching lines...) Expand 10 before | Expand all | Expand 10 after
832 break; 832 break;
833 case kX64Sub: 833 case kX64Sub:
834 ASSEMBLE_BINOP(subq); 834 ASSEMBLE_BINOP(subq);
835 break; 835 break;
836 case kX64And32: 836 case kX64And32:
837 ASSEMBLE_BINOP(andl); 837 ASSEMBLE_BINOP(andl);
838 break; 838 break;
839 case kX64And: 839 case kX64And:
840 ASSEMBLE_BINOP(andq); 840 ASSEMBLE_BINOP(andq);
841 break; 841 break;
842 case kX64Cmp8:
843 ASSEMBLE_COMPARE(cmpb);
844 break;
845 case kX64Cmp16:
846 ASSEMBLE_COMPARE(cmpw);
847 break;
842 case kX64Cmp32: 848 case kX64Cmp32:
843 ASSEMBLE_COMPARE(cmpl); 849 ASSEMBLE_COMPARE(cmpl);
844 break; 850 break;
845 case kX64Cmp: 851 case kX64Cmp:
846 ASSEMBLE_COMPARE(cmpq); 852 ASSEMBLE_COMPARE(cmpq);
847 break; 853 break;
854 case kX64Test8:
855 ASSEMBLE_COMPARE(testb);
856 break;
857 case kX64Test16:
858 ASSEMBLE_COMPARE(testw);
859 break;
848 case kX64Test32: 860 case kX64Test32:
849 ASSEMBLE_COMPARE(testl); 861 ASSEMBLE_COMPARE(testl);
850 break; 862 break;
851 case kX64Test: 863 case kX64Test:
852 ASSEMBLE_COMPARE(testq); 864 ASSEMBLE_COMPARE(testq);
853 break; 865 break;
854 case kX64Imul32: 866 case kX64Imul32:
855 ASSEMBLE_MULT(imull); 867 ASSEMBLE_MULT(imull);
856 break; 868 break;
857 case kX64Imul: 869 case kX64Imul:
(...skipping 1375 matching lines...) Expand 10 before | Expand all | Expand 10 after
2233 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc; 2245 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc;
2234 __ Nop(padding_size); 2246 __ Nop(padding_size);
2235 } 2247 }
2236 } 2248 }
2237 2249
2238 #undef __ 2250 #undef __
2239 2251
2240 } // namespace compiler 2252 } // namespace compiler
2241 } // namespace internal 2253 } // namespace internal
2242 } // namespace v8 2254 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/code-stub-assembler.cc ('k') | src/compiler/x64/instruction-codes-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698