Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: src/compiler.cc

Issue 1780193002: [compiler] Sidestep the interpreter for generator literals. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_interpreter-generators-disable-2
Patch Set: Rebased. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/mjsunit.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 755be2a3e525a23a102b5f36f189359fde32e377..47b555c27706a8d9c65f53f856a9c4b3afaac916 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -793,7 +793,8 @@ static bool UseIgnition(CompilationInfo* info) {
}
// TODO(4681): Generators are not yet supported.
- if (info->has_shared_info() && info->shared_info()->is_generator()) {
+ if ((info->has_shared_info() && info->shared_info()->is_generator()) ||
+ (info->has_literal() && IsGeneratorFunction(info->literal()->kind()))) {
return false;
}
« no previous file with comments | « no previous file | test/mjsunit/mjsunit.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698