Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1780193002: [compiler] Sidestep the interpreter for generator literals. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_interpreter-generators-disable-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Sidestep the interpreter for generator literals. This is because compiler.cc is awesome. There are cases where we do not yet have a SharedFunctionInfo that can tell us whether we are compiling a generator function, we query the FunctionLiteral instead. R=rmcilroy@chromium.org BUG=v8:4681 LOG=n Committed: https://crrev.com/5bd307fa722022217a9296f41572e561dbf68498 Cr-Commit-Position: refs/heads/master@{#34677}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -58 lines) Patch
M src/compiler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 2 chunks +1 line, -14 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-10 14:05:31 UTC) #1
rmcilroy
Nice, thanks! LGTM.
4 years, 9 months ago (2016-03-10 14:30:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780193002/20001
4 years, 9 months ago (2016-03-10 14:32:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-10 14:34:52 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 14:35:46 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5bd307fa722022217a9296f41572e561dbf68498
Cr-Commit-Position: refs/heads/master@{#34677}

Powered by Google App Engine
This is Rietveld 408576698