Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserverController.h

Issue 1780163002: Revert of IntersectionObserver: use an idle callback to send notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/IntersectionObserverController.h
diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserverController.h b/third_party/WebKit/Source/core/dom/IntersectionObserverController.h
index 089f9fa0fdd252d5a2a0f56baf36aabbd7976a1a..554f574b2beceb4717c5d85d37a2aa97746b1833 100644
--- a/third_party/WebKit/Source/core/dom/IntersectionObserverController.h
+++ b/third_party/WebKit/Source/core/dom/IntersectionObserverController.h
@@ -7,8 +7,8 @@
#include "core/dom/ActiveDOMObject.h"
#include "core/dom/Element.h"
-#include "core/dom/IdleRequestCallback.h"
#include "core/dom/IntersectionObserver.h"
+#include "platform/Timer.h"
#include "platform/heap/Handle.h"
#include "wtf/HashSet.h"
@@ -17,17 +17,16 @@
namespace blink {
-class IntersectionObserverController : public IdleRequestCallback, public ActiveDOMObject {
+class IntersectionObserverController : public GarbageCollectedFinalized<IntersectionObserverController>, public ActiveDOMObject {
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(IntersectionObserverController);
public:
static IntersectionObserverController* create(Document*);
~IntersectionObserverController();
void resume() override;
- void handleEvent(IdleDeadline*) override;
void scheduleIntersectionObserverForDelivery(IntersectionObserver&);
- void deliverIntersectionObservations();
+ void deliverIntersectionObservations(Timer<IntersectionObserverController>*);
void computeTrackedIntersectionObservations();
void addTrackedObserver(IntersectionObserver&);
void removeTrackedObserversForRoot(const Node&);
@@ -38,13 +37,13 @@
explicit IntersectionObserverController(Document*);
private:
+ Timer<IntersectionObserverController> m_timer;
// IntersectionObservers for which this is the tracking document.
HeapHashSet<WeakMember<IntersectionObserver>> m_trackedIntersectionObservers;
// IntersectionObservers for which this is the execution context of the callback.
HeapHashSet<Member<IntersectionObserver>> m_pendingIntersectionObservers;
- bool m_callbackIsScheduled;
- bool m_callbackFiredWhileSuspended;
+ bool m_timerFiredWhileSuspended;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698