Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: third_party/WebKit/LayoutTests/intersection-observer/same-document-no-root.html

Issue 1780163002: Revert of IntersectionObserver: use an idle callback to send notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/intersection-observer/same-document-no-root.html
diff --git a/third_party/WebKit/LayoutTests/intersection-observer/same-document-no-root.html b/third_party/WebKit/LayoutTests/intersection-observer/same-document-no-root.html
index 5d8a01b82285952ccb694fcc3a6312d4aff068d8..168a2cfce38091a43a5ed2cf94e3eea1f34e1e6f 100644
--- a/third_party/WebKit/LayoutTests/intersection-observer/same-document-no-root.html
+++ b/third_party/WebKit/LayoutTests/intersection-observer/same-document-no-root.html
@@ -6,67 +6,68 @@
<div style="width:100%; height:700px;"></div>
<script>
-description("Simple intersection observer test with no explicit root and one document.");
-var target = document.getElementById("target");
-var entries = [];
-var observer = new IntersectionObserver(changes => { entries = entries.concat(changes) });
+ description("Simple intersection observer test with no explicit root and one document.");
+ var target = document.getElementById("target");
+ var entries = [];
+ observer_callback = function(changes) {
+ for (var i in changes)
+ entries.push(changes[i]);
+ };
+ var observer = new IntersectionObserver(observer_callback, {});
+ observer.observe(target);
-onload = function() {
- observer.observe(target);
- entries = entries.concat(observer.takeRecords());
- shouldBeEqualToNumber("entries.length", 0);
- document.scrollingElement.scrollTop = 300;
- // See README for explanation of double RAF.
- requestAnimationFrame(() => { requestAnimationFrame(step1) });
-};
+ onload = function() {
+ shouldBeEqualToNumber("entries.length", 0);
+ document.scrollingElement.scrollTop = 300;
+ requestAnimationFrame(step1);
+ };
-function step1() {
- entries = entries.concat(observer.takeRecords());
- shouldBeEqualToNumber("entries.length", 1);
- if (entries.length > 0) {
- shouldBeEqualToNumber("entries[0].boundingClientRect.left", 8);
- shouldBeEqualToNumber("entries[0].boundingClientRect.right", 108);
- shouldBeEqualToNumber("entries[0].boundingClientRect.top", 408);
- shouldBeEqualToNumber("entries[0].boundingClientRect.bottom", 508);
- shouldBeEqualToNumber("entries[0].intersectionRect.left", 8);
- shouldBeEqualToNumber("entries[0].intersectionRect.right", 108);
- shouldBeEqualToNumber("entries[0].intersectionRect.top", 408);
- shouldBeEqualToNumber("entries[0].intersectionRect.bottom", 508);
- shouldBeEqualToNumber("entries[0].rootBounds.left", 0);
- shouldBeEqualToNumber("entries[0].rootBounds.right", 785);
- shouldBeEqualToNumber("entries[0].rootBounds.top", 0);
- shouldBeEqualToNumber("entries[0].rootBounds.bottom", 600);
- shouldEvaluateToSameObject("entries[0].target", target);
+ function step1() {
+ setTimeout(function() {
+ shouldBeEqualToNumber("entries.length", 1);
+ shouldBeEqualToNumber("entries[0].boundingClientRect.left", 8);
+ shouldBeEqualToNumber("entries[0].boundingClientRect.right", 108);
+ shouldBeEqualToNumber("entries[0].boundingClientRect.top", 408);
+ shouldBeEqualToNumber("entries[0].boundingClientRect.bottom", 508);
+ shouldBeEqualToNumber("entries[0].intersectionRect.left", 8);
+ shouldBeEqualToNumber("entries[0].intersectionRect.right", 108);
+ shouldBeEqualToNumber("entries[0].intersectionRect.top", 408);
+ shouldBeEqualToNumber("entries[0].intersectionRect.bottom", 508);
+ shouldBeEqualToNumber("entries[0].rootBounds.left", 0);
+ shouldBeEqualToNumber("entries[0].rootBounds.right", 785);
+ shouldBeEqualToNumber("entries[0].rootBounds.top", 0);
+ shouldBeEqualToNumber("entries[0].rootBounds.bottom", 600);
+ shouldEvaluateToSameObject("entries[0].target", target);
- // ClientRect members of IntersectionObserverEntry should be stable.
- shouldEvaluateToSameObject("entries[0].boundingClientRect", entries[0].boundingClientRect);
- shouldEvaluateToSameObject("entries[0].intersectionRect", entries[0].intersectionRect);
- shouldEvaluateToSameObject("entries[0].rootBounds", entries[0].rootBounds);
+ // ClientRect members of IntersectionObserverEntry should be stable.
+ shouldEvaluateToSameObject("entries[0].boundingClientRect", entries[0].boundingClientRect);
+ shouldEvaluateToSameObject("entries[0].intersectionRect", entries[0].intersectionRect);
+ shouldEvaluateToSameObject("entries[0].rootBounds", entries[0].rootBounds);
+
+ document.scrollingElement.scrollTop = 100;
+ requestAnimationFrame(step2);
+ });
}
- document.scrollingElement.scrollTop = 100;
- requestAnimationFrame(step2);
-}
-function step2() {
- entries = entries.concat(observer.takeRecords());
- shouldBeEqualToNumber("entries.length", 2);
- if (entries.length > 1) {
- shouldBeEqualToNumber("entries[1].boundingClientRect.left", 8);
- shouldBeEqualToNumber("entries[1].boundingClientRect.right", 108);
- shouldBeEqualToNumber("entries[1].boundingClientRect.top", 608);
- shouldBeEqualToNumber("entries[1].boundingClientRect.bottom", 708);
- shouldBeEqualToNumber("entries[1].intersectionRect.left", 0);
- shouldBeEqualToNumber("entries[1].intersectionRect.right", 0);
- shouldBeEqualToNumber("entries[1].intersectionRect.top", 0);
- shouldBeEqualToNumber("entries[1].intersectionRect.bottom", 0);
- shouldBeEqualToNumber("entries[1].rootBounds.left", 0);
- shouldBeEqualToNumber("entries[1].rootBounds.right", 785);
- shouldBeEqualToNumber("entries[1].rootBounds.top", 0);
- shouldBeEqualToNumber("entries[1].rootBounds.bottom", 600);
- shouldEvaluateToSameObject("entries[1].target", target);
+ function step2() {
+ setTimeout(function() {
+ shouldBeEqualToNumber("entries.length", 2);
+ shouldBeEqualToNumber("entries[1].boundingClientRect.left", 8);
+ shouldBeEqualToNumber("entries[1].boundingClientRect.right", 108);
+ shouldBeEqualToNumber("entries[1].boundingClientRect.top", 608);
+ shouldBeEqualToNumber("entries[1].boundingClientRect.bottom", 708);
+ shouldBeEqualToNumber("entries[1].intersectionRect.left", 0);
+ shouldBeEqualToNumber("entries[1].intersectionRect.right", 0);
+ shouldBeEqualToNumber("entries[1].intersectionRect.top", 0);
+ shouldBeEqualToNumber("entries[1].intersectionRect.bottom", 0);
+ shouldBeEqualToNumber("entries[1].rootBounds.left", 0);
+ shouldBeEqualToNumber("entries[1].rootBounds.right", 785);
+ shouldBeEqualToNumber("entries[1].rootBounds.top", 0);
+ shouldBeEqualToNumber("entries[1].rootBounds.bottom", 600);
+ shouldEvaluateToSameObject("entries[1].target", target);
+ finishJSTest();
+ document.scrollingElement.scrollTop = 0;
+ });
}
- finishJSTest();
- document.scrollingElement.scrollTop = 0;
-}
</script>

Powered by Google App Engine
This is Rietveld 408576698