Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: content/renderer/dom_serializer_browsertest.cc

Issue 1780143002: Disable flaky DomSerializerBrowserTests on all platforms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 622 matching lines...) Expand 10 before | Expand all | Expand 10 after
633 } 633 }
634 634
635 private: 635 private:
636 int32_t render_view_routing_id_; 636 int32_t render_view_routing_id_;
637 std::string serialized_contents_; 637 std::string serialized_contents_;
638 bool serialization_reported_end_of_data_; 638 bool serialization_reported_end_of_data_;
639 }; 639 };
640 640
641 // If original contents have document type, the serialized contents also have 641 // If original contents have document type, the serialized contents also have
642 // document type. 642 // document type.
643 // Disabled by ellyjones@ on 2015-05-18, see https://crbug.com/488495. 643 // Disabled on OSX by ellyjones@ on 2015-05-18, see https://crbug.com/488495,
644 #if defined(OS_MACOSX) 644 // on all platforms by tsergeant@ on 2016-03-10, see https://crbug.com/593575
645 #define MAYBE_SerializeHTMLDOMWithDocType DISABLED_SerializeHTMLDOMWithDocType
646 #else
647 #define MAYBE_SerializeHTMLDOMWithDocType SerializeHTMLDOMWithDocType
648 #endif
649 645
650 IN_PROC_BROWSER_TEST_F(DomSerializerTests, 646 IN_PROC_BROWSER_TEST_F(DomSerializerTests,
651 MAYBE_SerializeHTMLDOMWithDocType) { 647 DISABLED_SerializeHTMLDOMWithDocType) {
652 base::FilePath page_file_path = 648 base::FilePath page_file_path =
653 GetTestFilePath("dom_serializer", "youtube_1.htm"); 649 GetTestFilePath("dom_serializer", "youtube_1.htm");
654 GURL file_url = net::FilePathToFileURL(page_file_path); 650 GURL file_url = net::FilePathToFileURL(page_file_path);
655 ASSERT_TRUE(file_url.SchemeIsFile()); 651 ASSERT_TRUE(file_url.SchemeIsFile());
656 // Load the test file. 652 // Load the test file.
657 NavigateToURL(shell(), file_url); 653 NavigateToURL(shell(), file_url);
658 654
659 PostTaskToInProcessRendererAndWait( 655 PostTaskToInProcessRendererAndWait(
660 base::Bind(&DomSerializerTests::SerializeHTMLDOMWithDocTypeOnRenderer, 656 base::Bind(&DomSerializerTests::SerializeHTMLDOMWithDocTypeOnRenderer,
661 base::Unretained(this), file_url)); 657 base::Unretained(this), file_url));
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
718 PostTaskToInProcessRendererAndWait( 714 PostTaskToInProcessRendererAndWait(
719 base::Bind( 715 base::Bind(
720 &DomSerializerTests::SerializeHTMLDOMWithAddingMOTWOnRenderer, 716 &DomSerializerTests::SerializeHTMLDOMWithAddingMOTWOnRenderer,
721 base::Unretained(this), file_url, original_contents)); 717 base::Unretained(this), file_url, original_contents));
722 } 718 }
723 719
724 // When serializing DOM, we will add the META which have correct charset 720 // When serializing DOM, we will add the META which have correct charset
725 // declaration as first child of HEAD element for resolving WebKit bug: 721 // declaration as first child of HEAD element for resolving WebKit bug:
726 // http://bugs.webkit.org/show_bug.cgi?id=16621 even the original document 722 // http://bugs.webkit.org/show_bug.cgi?id=16621 even the original document
727 // does not have META charset declaration. 723 // does not have META charset declaration.
728 // Disabled by battre@ on 2015-05-21, see https://crbug.com/488495. 724 // Disabled on OSX by battre@ on 2015-05-21, see https://crbug.com/488495,
729 #if defined(OS_MACOSX) 725 // on all platforms by tsergeant@ on 2016-03-10, see https://crbug.com/593575
730 #define MAYBE_SerializeHTMLDOMWithNoMetaCharsetInOriginalDoc \ 726 IN_PROC_BROWSER_TEST_F(
731 DISABLED_SerializeHTMLDOMWithNoMetaCharsetInOriginalDoc 727 DomSerializerTests,
732 #else 728 DISABLED_SerializeHTMLDOMWithNoMetaCharsetInOriginalDoc) {
733 #define MAYBE_SerializeHTMLDOMWithNoMetaCharsetInOriginalDoc \
734 SerializeHTMLDOMWithNoMetaCharsetInOriginalDoc
735 #endif
736 IN_PROC_BROWSER_TEST_F(DomSerializerTests,
737 MAYBE_SerializeHTMLDOMWithNoMetaCharsetInOriginalDoc) {
738 base::FilePath page_file_path = 729 base::FilePath page_file_path =
739 GetTestFilePath("dom_serializer", "youtube_1.htm"); 730 GetTestFilePath("dom_serializer", "youtube_1.htm");
740 // Get file URL. 731 // Get file URL.
741 GURL file_url = net::FilePathToFileURL(page_file_path); 732 GURL file_url = net::FilePathToFileURL(page_file_path);
742 ASSERT_TRUE(file_url.SchemeIsFile()); 733 ASSERT_TRUE(file_url.SchemeIsFile());
743 // Load the test file. 734 // Load the test file.
744 NavigateToURL(shell(), file_url); 735 NavigateToURL(shell(), file_url);
745 736
746 PostTaskToInProcessRendererAndWait( 737 PostTaskToInProcessRendererAndWait(
747 base::Bind( 738 base::Bind(
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
865 NavigateToURL(shell(), file_url); 856 NavigateToURL(shell(), file_url);
866 857
867 PostTaskToInProcessRendererAndWait( 858 PostTaskToInProcessRendererAndWait(
868 base::Bind( 859 base::Bind(
869 &DomSerializerTests:: 860 &DomSerializerTests::
870 SubResourceForElementsInNonHTMLNamespaceOnRenderer, 861 SubResourceForElementsInNonHTMLNamespaceOnRenderer,
871 base::Unretained(this), file_url)); 862 base::Unretained(this), file_url));
872 } 863 }
873 864
874 } // namespace content 865 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698