Issue 178014: Rebasline a test + more bug reorganization....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 178014: Rebasline a test + more bug reorganization.... (Closed)

Created:
11 years, 3 months ago by Nate Chapin

Modified:
9 years, 5 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, Pam (message me for reviews), darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Rebasline a test + more bug reorganization. BUG=10398 TEST=green webkit builders Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24772

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+409 lines, -35 lines)			Patch
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/events/pointer-events-2-expected.checksum	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/events/pointer-events-2-expected.png	View	1	Binary file		0 comments	Download
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/events/pointer-events-2-expected.txt	View	1	1 chunk	+199 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/events/pointer-events-2-expected.checksum	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/events/pointer-events-2-expected.png	View	1	Binary file		0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/events/pointer-events-2-expected.txt	View	1	1 chunk	+199 lines, -0 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View	1 2 3	6 chunks	+9 lines, -35 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dglazkov

11 years, 3 months ago (2009-08-28 18:26:09 UTC) #2

LGTM, but please check to make sure you haven't accidentally overwrote
test_expectations changes.

http://codereview.chromium.org/178014/diff/9/10
File webkit/tools/layout_tests/test_expectations.txt (right):

http://codereview.chromium.org/178014/diff/9/10#newcode2705
Line 2705: BUG20332 : LayoutTests/fast/events/keydown-function-keys.html = FAIL
Do you have an older test_expecations perhaps? :)

Expand Messages | Collapse Messages