Minor library function fixes for TypedArray spec compliance

Minor library function fixes for TypedArray spec compliance

- Make separate iterator functions for TypedArrays which do a type check
  (and in the future should check for detached TypedArrays)
- Share the toString method with Arrays

BUG=v8:4785
R=adamk
LOG=Y

Committed: https://crrev.com/611add52550510b6bc0b79f6ae9278786183405f
Cr-Commit-Position: refs/heads/master@{#34698}

[Dan Ehrenberg, 2016-03-10 02:31:28]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-10 02:31:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780113002/1

[commit-bot: I haz the power, 2016-03-10 02:33:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 02:33:12]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/16779)

[Dan Ehrenberg, 2016-03-10 20:11:48]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-10 20:11:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780113002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780113002/20001

[Dan Ehrenberg, 2016-03-10 20:19:14]

The CQ bit was unchecked by littledan@chromium.org

[Dan Ehrenberg, 2016-03-10 20:32:56]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-10 20:33:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780113002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780113002/40001

[Dan Ehrenberg, 2016-03-10 20:38:59]

The CQ bit was unchecked by littledan@chromium.org

[Dan Ehrenberg, 2016-03-10 22:07:39]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-10 22:07:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780113002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780113002/60001

[adamk, 2016-03-10 23:10:42]

lgtm % nits

https://codereview.chromium.org/1780113002/diff/60001/src/js/array-iterator.js
File src/js/array-iterator.js (right):

https://codereview.chromium.org/1780113002/diff/60001/src/js/array-iterator.j...
src/js/array-iterator.js:112: // TODO(littledan): ValidateTypedArray before each
of these three
Is this about detachment? Can you make this more explicit in the comment?

https://codereview.chromium.org/1780113002/diff/60001/src/js/typedarray.js
File src/js/typedarray.js (right):

https://codereview.chromium.org/1780113002/diff/60001/src/js/typedarray.js#ne...
src/js/typedarray.js:882: %AddNamedProperty(TypedArray.prototype, "toString",
ArrayToString,
Can you mention this in the CL description too?

[Dan Ehrenberg, 2016-03-10 23:16:09]

Description was changed from

==========
Make separate iterator functions for TypedArrays

BUG=v8:4785
R=adamk
LOG=Y
==========

to

==========
Minor library function fixes for TypedArray spec compliance

- Make separate iterator functions for TypedArrays which do a type check
  (and in the future should check for detached TypedArrays)
- Share the toString method with Arrays

BUG=v8:4785
R=adamk
LOG=Y
==========

[Dan Ehrenberg, 2016-03-10 23:16:34]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-03-10 23:16:35]

https://codereview.chromium.org/1780113002/diff/60001/src/js/array-iterator.js
File src/js/array-iterator.js (right):

https://codereview.chromium.org/1780113002/diff/60001/src/js/array-iterator.j...
src/js/array-iterator.js:112: // TODO(littledan): ValidateTypedArray before each
of these three
On 2016/03/10 at 23:10:42, adamk wrote:
> Is this about detachment? Can you make this more explicit in the comment?

Done

https://codereview.chromium.org/1780113002/diff/60001/src/js/typedarray.js
File src/js/typedarray.js (right):

https://codereview.chromium.org/1780113002/diff/60001/src/js/typedarray.js#ne...
src/js/typedarray.js:882: %AddNamedProperty(TypedArray.prototype, "toString",
ArrayToString,
On 2016/03/10 at 23:10:42, adamk wrote:
> Can you mention this in the CL description too?

Done

[Dan Ehrenberg, 2016-03-10 23:16:35]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1780113002/#ps80001
(title: "Improve comment")

[commit-bot: I haz the power, 2016-03-10 23:16:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780113002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780113002/80001

[commit-bot: I haz the power, 2016-03-10 23:37:26]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-10 23:38:24]

Description was changed from

==========
Minor library function fixes for TypedArray spec compliance

- Make separate iterator functions for TypedArrays which do a type check
  (and in the future should check for detached TypedArrays)
- Share the toString method with Arrays

BUG=v8:4785
R=adamk
LOG=Y
==========

to

==========
Minor library function fixes for TypedArray spec compliance

- Make separate iterator functions for TypedArrays which do a type check
  (and in the future should check for detached TypedArrays)
- Share the toString method with Arrays

BUG=v8:4785
R=adamk
LOG=Y

Committed: https://crrev.com/611add52550510b6bc0b79f6ae9278786183405f
Cr-Commit-Position: refs/heads/master@{#34698}
==========

[commit-bot: I haz the power, 2016-03-10 23:38:25]

Patchset 5 (id:??) landed as
https://crrev.com/611add52550510b6bc0b79f6ae9278786183405f
Cr-Commit-Position: refs/heads/master@{#34698}