Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1780093003: Remove CFX_DWordArray from Document.h (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove CFX_DWordArray from Document.h Using a list is more appropriate, since we wish to delete from the middle. R=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/56c1019e694ba9c2d6624d3c11d99c22798ffdc8

Patch Set 1 #

Patch Set 2 : std::swap() not required. #

Patch Set 3 : rebase past rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -47 lines) Patch
M fpdfsdk/javascript/Document.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 2 3 chunks +16 lines, -46 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
For review.
4 years, 9 months ago (2016-03-11 00:45:50 UTC) #2
dsinclair
lgtm
4 years, 9 months ago (2016-03-15 13:30:42 UTC) #3
Tom Sepez
4 years, 9 months ago (2016-03-15 19:34:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
56c1019e694ba9c2d6624d3c11d99c22798ffdc8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698