Introduce Platform::setCurrentPlatformForTesting

Introduce Platform::setCurrentPlatformForTesting

In preparation for cleaning up the initialization/shutdown logic of Blink,
I need to make Platfrom::initialize() and Platform::shutdown() are balanced
(i.e., Platfrom::initialize() and Platform::shutdown() should be called only once
respectively.)

Currently TestingPlatformSupport violates the contract (i.e., it calls Platfrom::initialize()
multiple times). This CL introduces Platform::setCurrentPlatformForTesting
and makes sure that Platfrom::initialize() is called only once.

BUG=593269
Committed: https://crrev.com/1ec0cea30571de24eb8cc243c867ed346a9205ad
Cr-Commit-Position: refs/heads/master@{#380370}

[haraken, 2016-03-10 00:18:40]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com, tkent@chromium.org

[haraken, 2016-03-10 00:18:40]

PTAL

[tkent, 2016-03-10 00:24:22]

Do you need to update ScrollableAreaTest.cpp and
CompositorAnimationTestHelper.cpp?

https://code.google.com/p/chromium/codesearch#search/&q=Platform%5C:%5C:initi...

[haraken, 2016-03-10 00:26:58]

On 2016/03/10 00:24:22, tkent wrote:
> Do you need to update ScrollableAreaTest.cpp and
> CompositorAnimationTestHelper.cpp?
> 
>
https://code.google.com/p/chromium/codesearch#search/&q=Platform%5C:%5C:initi...

Thanks for pointing it out. Done.

(I was wondering why webkit_unit_tests didn't fail without changing those code
though.)

[tkent, 2016-03-10 00:32:48]

lgtm

[haraken, 2016-03-10 00:35:38]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-03-10 00:36:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780083002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780083002/20001

[commit-bot: I haz the power, 2016-03-10 01:54:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 01:54:19]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sof, 2016-03-10 06:09:51]

lgtm

https://codereview.chromium.org/1780083002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/CompositorAnimationsTestHelper.h
(right):

https://codereview.chromium.org/1780083002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/CompositorAnimationsTestHelper.h:140:
TestingPlatformSupport m_proxyPlatform;
can be removed, i think.

[haraken, 2016-03-10 06:12:34]

>
https://codereview.chromium.org/1780083002/diff/80001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/animation/CompositorAnimationsTestHelper.h
> (right):
> 
>
https://codereview.chromium.org/1780083002/diff/80001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/animation/CompositorAnimationsTestHelper.h:140:
> TestingPlatformSupport m_proxyPlatform;
> can be removed, i think.

Done.

[haraken, 2016-03-10 06:12:38]

The CQ bit was checked by haraken@chromium.org

[haraken, 2016-03-10 06:12:38]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/1780083002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-03-10 06:13:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1780083002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1780083002/100001

[commit-bot: I haz the power, 2016-03-10 07:26:54]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-10 07:28:06]

Description was changed from

==========
Introduce Platform::setCurrentPlatformForTesting

In preparation for cleaning up the initialization/shutdown logic of Blink,
I need to make Platfrom::initialize() and Platform::shutdown() are balanced
(i.e., Platfrom::initialize() and Platform::shutdown() should be called only
once
respectively.)

Currently TestingPlatformSupport violates the contract (i.e., it calls
Platfrom::initialize()
multiple times). This CL introduces Platform::setCurrentPlatformForTesting
and makes sure that Platfrom::initialize() is called only once.

BUG=593269
==========

to

==========
Introduce Platform::setCurrentPlatformForTesting

In preparation for cleaning up the initialization/shutdown logic of Blink,
I need to make Platfrom::initialize() and Platform::shutdown() are balanced
(i.e., Platfrom::initialize() and Platform::shutdown() should be called only
once
respectively.)

Currently TestingPlatformSupport violates the contract (i.e., it calls
Platfrom::initialize()
multiple times). This CL introduces Platform::setCurrentPlatformForTesting
and makes sure that Platfrom::initialize() is called only once.

BUG=593269

Committed: https://crrev.com/1ec0cea30571de24eb8cc243c867ed346a9205ad
Cr-Commit-Position: refs/heads/master@{#380370}
==========

[commit-bot: I haz the power, 2016-03-10 07:28:07]

Patchset 6 (id:??) landed as
https://crrev.com/1ec0cea30571de24eb8cc243c867ed346a9205ad
Cr-Commit-Position: refs/heads/master@{#380370}