chrome/browser/cocoa/toolbar_controller.mm - Issue 178007: [Mac] Tweaks to Omnibox metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/toolbar_controller.mm

Issue 178007: [Mac] Tweaks to Omnibox metrics. (Closed)

Patch Set: Oops, fixed unit test. Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/cocoa/toolbar_controller.mm

diff --git a/chrome/browser/cocoa/toolbar_controller.mm b/chrome/browser/cocoa/toolbar_controller.mm

index 718eb30a8952c95241641c23f66c953036555969..f3f36590742d260cfc8f6af78424a5554f8c38ba 100644

--- a/chrome/browser/cocoa/toolbar_controller.mm

+++ b/chrome/browser/cocoa/toolbar_controller.mm

@@ -412,7 +412,9 @@ class PrefObserverBridge : public NotificationObserver {

DCHECK(minX < NSMinX(locationFrame));

DCHECK(maxX > NSMaxX(locationFrame));

- NSRect r = NSMakeRect(minX, NSMinY(locationFrame), maxX - minX, 0);

+ // TODO(shess): The + 1.0 is because the field's visual boundary

+ // differs from its on-screen boundary.

+ NSRect r = NSMakeRect(minX, NSMinY(locationFrame) + 1.0, maxX - minX, 0);

return gfx::Rect(NSRectToCGRect([[self view] convertRect:r toView:nil]));

}

@end