Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 178007: [Mac] Tweaks to Omnibox metrics. (Closed)

Created:
11 years, 3 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

[Mac] Tweaks to Omnibox metrics. Pull in the popup corners by half a pixel to more closely match the rounding on the buttons. Pull up the gap between the popup and the field by one pixel to match Windows. http://crbug.com/20446

Patch Set 1 #

Patch Set 2 : Oops, fixed unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/browser/autocomplete/autocomplete_popup_view_mac.mm View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/autocomplete_text_field_cell.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/toolbar_controller.mm View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/cocoa/toolbar_controller_unittest.mm View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Scott Hess - ex-Googler
11 years, 3 months ago (2009-08-27 22:51:39 UTC) #1
rohitrao (ping after 24h)
11 years, 3 months ago (2009-08-28 17:21:10 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698