Issue 178007: [Mac] Tweaks to Omnibox metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 178007: [Mac] Tweaks to Omnibox metrics. (Closed)

Created:
11 years, 3 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

[Mac] Tweaks to Omnibox metrics. Pull in the popup corners by half a pixel to more closely match the rounding on the buttons. Pull up the gap between the popup and the field by one pixel to match Windows. http://crbug.com/20446

Patch Set 1 #

Patch Set 2 : Oops, fixed unit test. #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -5 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_popup_view_mac.mm	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/autocomplete_text_field_cell.mm	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/toolbar_controller.mm	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/toolbar_controller_unittest.mm	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages