Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 1780053002: [MD settings] favicons for OnStartup url settings (Closed)

Created:
4 years, 9 months ago by dschuyler
Modified:
4 years, 9 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] favicons for OnStartup url settings This CL changes the grey dot icon on the startup URL settings to the favicon for each URL. BUG=531750 Committed: https://crrev.com/9ef2c18816a6bd9526839999a7bf3635bb03f98c Cr-Commit-Position: refs/heads/master@{#380763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/browser/resources/settings/on_startup_page/startup_urls_page.html View 1 chunk +12 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_urls_page.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dschuyler
4 years, 9 months ago (2016-03-09 23:09:37 UTC) #2
dschuyler
On 2016/03/09 23:09:37, dschuyler wrote: A screenshot is at: http://imgur.com/dw1kRFN
4 years, 9 months ago (2016-03-10 00:23:27 UTC) #3
tommycli
lgtm
4 years, 9 months ago (2016-03-11 18:50:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780053002/1
4 years, 9 months ago (2016-03-11 21:20:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 22:40:59 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 22:42:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ef2c18816a6bd9526839999a7bf3635bb03f98c
Cr-Commit-Position: refs/heads/master@{#380763}

Powered by Google App Engine
This is Rietveld 408576698