Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1780043002: Add download button to MediaDocument on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use base::Feature instead of switches Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 754 matching lines...) Expand 10 before | Expand all | Expand 10 after
765 chromeos::switches::kDisableNetworkPortalNotification)}, 765 chromeos::switches::kDisableNetworkPortalNotification)},
766 #endif 766 #endif
767 {"enable-download-resumption", IDS_FLAGS_DOWNLOAD_RESUMPTION_NAME, 767 {"enable-download-resumption", IDS_FLAGS_DOWNLOAD_RESUMPTION_NAME,
768 IDS_FLAGS_DOWNLOAD_RESUMPTION_DESCRIPTION, kOsAll, 768 IDS_FLAGS_DOWNLOAD_RESUMPTION_DESCRIPTION, kOsAll,
769 FEATURE_VALUE_TYPE(features::kDownloadResumption)}, 769 FEATURE_VALUE_TYPE(features::kDownloadResumption)},
770 #if defined(OS_ANDROID) 770 #if defined(OS_ANDROID)
771 {"enable-system-download-manager", 771 {"enable-system-download-manager",
772 IDS_FLAGS_ENABLE_SYSTEM_DOWNLOAD_MANAGER_NAME, 772 IDS_FLAGS_ENABLE_SYSTEM_DOWNLOAD_MANAGER_NAME,
773 IDS_FLAGS_ENABLE_SYSTEM_DOWNLOAD_MANAGER_DESCRIPTION, kOsAndroid, 773 IDS_FLAGS_ENABLE_SYSTEM_DOWNLOAD_MANAGER_DESCRIPTION, kOsAndroid,
774 FEATURE_VALUE_TYPE(chrome::android::kSystemDownloadManager)}, 774 FEATURE_VALUE_TYPE(chrome::android::kSystemDownloadManager)},
775 {"enable-media-document-download-button",
776 IDS_FLAGS_MEDIA_DOCUMENT_DOWNLOAD_BUTTON_NAME,
777 IDS_FLAGS_MEDIA_DOCUMENT_DOWNLOAD_BUTTON_DESCRIPTION, kOsAndroid,
778 FEATURE_VALUE_TYPE(features::kMediaDocumentDownloadButton)},
775 #endif 779 #endif
776 #if defined(OS_CHROMEOS) 780 #if defined(OS_CHROMEOS)
777 {"download-notification", IDS_FLAGS_DOWNLOAD_NOTIFICATION_NAME, 781 {"download-notification", IDS_FLAGS_DOWNLOAD_NOTIFICATION_NAME,
778 IDS_FLAGS_DOWNLOAD_NOTIFICATION_DESCRIPTION, kOsCrOS, 782 IDS_FLAGS_DOWNLOAD_NOTIFICATION_DESCRIPTION, kOsCrOS,
779 SINGLE_DISABLE_VALUE_TYPE(switches::kDisableDownloadNotification)}, 783 SINGLE_DISABLE_VALUE_TYPE(switches::kDisableDownloadNotification)},
780 #endif 784 #endif
781 #if defined(ENABLE_PLUGINS) 785 #if defined(ENABLE_PLUGINS)
782 {"allow-nacl-socket-api", IDS_FLAGS_ALLOW_NACL_SOCKET_API_NAME, 786 {"allow-nacl-socket-api", IDS_FLAGS_ALLOW_NACL_SOCKET_API_NAME,
783 IDS_FLAGS_ALLOW_NACL_SOCKET_API_DESCRIPTION, kOsDesktop, 787 IDS_FLAGS_ALLOW_NACL_SOCKET_API_DESCRIPTION, kOsDesktop,
784 SINGLE_VALUE_TYPE_AND_VALUE(switches::kAllowNaClSocketAPI, "*")}, 788 SINGLE_VALUE_TYPE_AND_VALUE(switches::kAllowNaClSocketAPI, "*")},
(...skipping 1247 matching lines...) Expand 10 before | Expand all | Expand 10 after
2032 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2036 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2033 2037
2034 const FeatureEntry* GetFeatureEntries(size_t* count) { 2038 const FeatureEntry* GetFeatureEntries(size_t* count) {
2035 *count = arraysize(kFeatureEntries); 2039 *count = arraysize(kFeatureEntries);
2036 return kFeatureEntries; 2040 return kFeatureEntries;
2037 } 2041 }
2038 2042
2039 } // namespace testing 2043 } // namespace testing
2040 2044
2041 } // namespace about_flags 2045 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698