Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: net/base/net_errors.h

Issue 178003011: net: a weak DH key is not a certificate error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update comments in response to wtc's remarks. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_errors.h
diff --git a/net/base/net_errors.h b/net/base/net_errors.h
index c8742a8110df194d01666ebd46d20e8403c121c1..2c513612209f7c2eb08dc6c249160da506664b6f 100644
--- a/net/base/net_errors.h
+++ b/net/base/net_errors.h
@@ -36,8 +36,9 @@ NET_EXPORT const char* ErrorToString(int error);
inline bool IsCertificateError(int error) {
// Certificate errors are negative integers from net::ERR_CERT_BEGIN
// (inclusive) to net::ERR_CERT_END (exclusive) in *decreasing* order.
+ // ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN is currently an exception to this
+ // rule.
return (error <= ERR_CERT_BEGIN && error > ERR_CERT_END) ||
- (error == ERR_SSL_WEAK_SERVER_EPHEMERAL_DH_KEY) ||
(error == ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698