Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 178003003: Do not define SK_SUPPORT_DEEPCOPYTO_CONFIG in Skia. (Closed)

Created:
6 years, 10 months ago by reed1
Modified:
6 years, 10 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Do not define SK_SUPPORT_DEEPCOPYTO_CONFIG in Skia. Clean up our callers who depend on the deprecated function. Committed: http://code.google.com/p/skia/source/detail?r=13566

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix error of unused-function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M gm/gmmain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkBitmap.h View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/GpuBitmapCopyTest.cpp View 1 2 3 chunks +7 lines, -5 lines 0 comments Download
M tools/render_pdfs_main.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
reed1
6 years, 10 months ago (2014-02-24 16:12:45 UTC) #1
scroggo
On 2014/02/24 16:12:45, reed1 wrote: Change description? Something like: Do not define SK_SUPPORT_DEEPCOPYTO_CONFIG in Skia. ...
6 years, 10 months ago (2014-02-24 16:15:34 UTC) #2
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-24 16:23:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/178003003/1
6 years, 10 months ago (2014-02-24 16:23:42 UTC) #4
reed1
The CQ bit was unchecked by reed@google.com
6 years, 10 months ago (2014-02-24 16:23:57 UTC) #5
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-24 16:24:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/178003003/90001
6 years, 10 months ago (2014-02-24 16:24:12 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-24 17:25:22 UTC) #8
commit-bot: I haz the power
Retried try job too often on Build-Mac10.8-Clang-x86-Release-Trybot for step(s) BuildEverything, BuildTests http://108.170.219.164:10117/buildstatus?builder=Build-Mac10.8-Clang-x86-Release-Trybot&number=120
6 years, 10 months ago (2014-02-24 17:25:22 UTC) #9
reed1
The CQ bit was checked by reed@google.com
6 years, 10 months ago (2014-02-24 17:36:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/178003003/200001
6 years, 10 months ago (2014-02-24 17:36:15 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-24 18:51:49 UTC) #12
Message was sent while issue was closed. 
Change committed as 13566

Powered by Google App Engine
This is Rietveld 408576698