Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Issue 1779943002: Fix path error in getting depot dir. (Closed)

Created:
4 years, 9 months ago by chrisphan
Modified:
4 years, 9 months ago
Reviewers:
prasadv
CC:
chromium-reviews, auto-bisect-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix path error in getting depot dir. For some reason it's failing get GetPotDir from incorrect path. Change here is to use path from BisectPerformanceMetrics instance to generate bisect result json. Committed: https://crrev.com/fabd08d77b7cf87d1047d77a38fcb4585d6fe82c Cr-Commit-Position: refs/heads/master@{#380270}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M tools/auto_bisect/bisect_perf_regression.py View 3 chunks +18 lines, -19 lines 0 comments Download
M tools/auto_bisect/bisect_perf_regression_test.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
chrisphan
4 years, 9 months ago (2016-03-09 21:13:13 UTC) #2
prasadv
lgtm
4 years, 9 months ago (2016-03-09 22:06:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779943002/1
4 years, 9 months ago (2016-03-09 23:17:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 00:23:32 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 00:24:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fabd08d77b7cf87d1047d77a38fcb4585d6fe82c
Cr-Commit-Position: refs/heads/master@{#380270}

Powered by Google App Engine
This is Rietveld 408576698