Create explicit microhttpd.gyp

Create explicit microhttpd.gyp

Committed: https://skia.googlesource.com/skia/+/80993639dfb8bcd26633ba1c3b7334f3ef7f6eb8
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1779903002

Committed: https://skia.googlesource.com/skia/+/5ec9132e55d207e7b19adfd532ee9f05b7172976

[joshua.litt, 2016-03-09 19:36:10]

Description was changed from

==========
Create explicit microhttpd.gyp

BUG=skia:
==========

to

==========
Create explicit microhttpd.gyp

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-03-09 19:43:02]

joshualitt@google.com changed reviewers:
+ bungeman@google.com, ethannicholas@google.com, jcgregorio@google.com,
joshualitt@google.com

[joshualitt, 2016-03-09 19:43:02]

ptal, this moves to a gyp based build system.  Ben, do I need to take anything
from the old gyp?

[joshualitt, 2016-03-09 20:32:58]

On 2016/03/09 19:43:02, joshualitt wrote:
> ptal, this moves to a gyp based build system.  Ben, do I need to take anything
> from the old gyp?

fixed mac build, ptal

[bungeman-skia, 2016-03-09 20:57:01]

https://codereview.chromium.org/1779903002/diff/80001/gyp/microhttpd.gyp
File gyp/microhttpd.gyp (right):

https://codereview.chromium.org/1779903002/diff/80001/gyp/microhttpd.gyp#newc...
gyp/microhttpd.gyp:40: 'defines=': [             # equals sign throws away most
Skia defines (just noise)
It should at least save some time in the future if there were some short
description of how to obtain these defines.

https://codereview.chromium.org/1779903002/diff/80001/gyp/microhttpd.gyp#newc...
gyp/microhttpd.gyp:113: 'include_dirs': [
It seems these are always going to be the include_dirs no matter the platform,
can we pull these out from the conditional?

[joshualitt, 2016-03-09 21:46:57]

On 2016/03/09 20:57:01, bungeman1 wrote:
> https://codereview.chromium.org/1779903002/diff/80001/gyp/microhttpd.gyp
> File gyp/microhttpd.gyp (right):
> 
>
https://codereview.chromium.org/1779903002/diff/80001/gyp/microhttpd.gyp#newc...
> gyp/microhttpd.gyp:40: 'defines=': [             # equals sign throws away
most
> Skia defines (just noise)
> It should at least save some time in the future if there were some short
> description of how to obtain these defines.
done
> 
>
https://codereview.chromium.org/1779903002/diff/80001/gyp/microhttpd.gyp#newc...
> gyp/microhttpd.gyp:113: 'include_dirs': [
> It seems these are always going to be the include_dirs no matter the platform,
> can we pull these out from the conditional?

done

[bungeman-skia, 2016-03-09 21:48:15]

The CQ bit was checked by bungeman@google.com

[bungeman-skia, 2016-03-09 21:48:16]

lgtm

[commit-bot: I haz the power, 2016-03-09 21:48:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1779903002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1779903002/100001

[bungeman-skia, 2016-03-09 21:48:27]

Description was changed from

==========
Create explicit microhttpd.gyp

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Create explicit microhttpd.gyp
==========

[commit-bot: I haz the power, 2016-03-09 22:00:54]

Description was changed from

==========
Create explicit microhttpd.gyp
==========

to

==========
Create explicit microhttpd.gyp

Committed:
https://skia.googlesource.com/skia/+/80993639dfb8bcd26633ba1c3b7334f3ef7f6eb8
==========

[commit-bot: I haz the power, 2016-03-09 22:00:55]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/80993639dfb8bcd26633ba1c3b7334f3ef7f6eb8

[joshualitt, 2016-03-09 22:26:08]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1781853002/ by joshualitt@google.com.

The reason for reverting is: breaking per commit housekeeper.

[joshua.litt, 2016-03-09 22:39:16]

Description was changed from

==========
Create explicit microhttpd.gyp

Committed:
https://skia.googlesource.com/skia/+/80993639dfb8bcd26633ba1c3b7334f3ef7f6eb8
==========

to

==========
Create explicit microhttpd.gyp

Committed:
https://skia.googlesource.com/skia/+/80993639dfb8bcd26633ba1c3b7334f3ef7f6eb8
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-03-09 22:39:34]

Description was changed from

==========
Create explicit microhttpd.gyp

Committed:
https://skia.googlesource.com/skia/+/80993639dfb8bcd26633ba1c3b7334f3ef7f6eb8
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Create explicit microhttpd.gyp

Committed:
https://skia.googlesource.com/skia/+/80993639dfb8bcd26633ba1c3b7334f3ef7f6eb8
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-03-09 22:50:13]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2016-03-09 22:50:13]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com
Link to the patchset: https://codereview.chromium.org/1779903002/#ps120001
(title: "presubmit fix?")

[commit-bot: I haz the power, 2016-03-09 22:50:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1779903002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1779903002/120001

[commit-bot: I haz the power, 2016-03-09 23:07:04]

Description was changed from

==========
Create explicit microhttpd.gyp

Committed:
https://skia.googlesource.com/skia/+/80993639dfb8bcd26633ba1c3b7334f3ef7f6eb8
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Create explicit microhttpd.gyp

Committed:
https://skia.googlesource.com/skia/+/80993639dfb8bcd26633ba1c3b7334f3ef7f6eb8
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/5ec9132e55d207e7b19adfd532ee9f05b7172976
==========

[commit-bot: I haz the power, 2016-03-09 23:07:05]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/5ec9132e55d207e7b19adfd532ee9f05b7172976