net/tools/quic/quic_dispatcher.cc - Issue 1779883005: Remove unused return value from QuicAlarm::Delegate::OnAlarm. No behavior change, not protected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_dispatcher.cc

Issue 1779883005: Remove unused return value from QuicAlarm::Delegate::OnAlarm. No behavior change, not protected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116388439

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/quic_dispatcher.cc

diff --git a/net/tools/quic/quic_dispatcher.cc b/net/tools/quic/quic_dispatcher.cc

index c7890e2affba6bba5af9e0110934bd2b889e0782..f662ee30d2955bda9f6a32ae01cfc85910197788 100644

--- a/net/tools/quic/quic_dispatcher.cc

+++ b/net/tools/quic/quic_dispatcher.cc

@@ -30,11 +30,7 @@ class DeleteSessionsAlarm : public QuicAlarm::Delegate {

explicit DeleteSessionsAlarm(QuicDispatcher* dispatcher)

: dispatcher_(dispatcher) {}

- QuicTime OnAlarm() override {

- dispatcher_->DeleteSessions();

- // Let the dispatcher register the alarm at appropriate time.

- return QuicTime::Zero();

- }

+ void OnAlarm() override { dispatcher_->DeleteSessions(); }

private:

// Not owned.

« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/tools/quic/quic_epoll_connection_helper_test.cc » ('j') | no next file with comments »