Switch Blink SkShader clients to sk_sp

Switch Blink SkShader clients to sk_sp

Skia is migrating its APIs to the new smart pointer type - sk_sp.  Among other
benefits, the new type/APIs help avoid atomic ref count churn thanks to
move semantics (ownership can now be transferred into Skia).

1) convert Blink shader wrappers (Gradient, Pattern) to store sk_sp<SkShader>
   (instead of RefPtr<SkShader>).
2) use sk_sp factories (MakeFoo instead of CreateFoo)
3) call the sk_sp paint shader setters - setShader(sk_sp<SkShader>) instead of
   setShader(SkShader*).

BUG=skia:5077
R=reed@google.com,schenney@chromium.org,junov@chromium.org,senorblanco@chromium.org

Committed: https://crrev.com/12e75e492a66e801b464eefa9b61d1c5058c0c5c
Cr-Commit-Position: refs/heads/master@{#380664}

[f(malita), 2016-03-09 18:37:17]

Description was changed from

==========
Switch SkShader clients to sk_sp

WIP

BUG=
==========

to

==========
Switch SkShader clients to sk_sp

WIP

BUG=skia:5077
==========

[f(malita), 2016-03-09 18:38:38]

Description was changed from

==========
Switch SkShader clients to sk_sp

WIP

BUG=skia:5077
==========

to

==========
Switch Blink SkShader clients to sk_sp

WIP

BUG=skia:5077
==========

[f(malita), 2016-03-09 18:51:51]

Description was changed from

==========
Switch Blink SkShader clients to sk_sp

WIP

BUG=skia:5077
==========

to

==========
Switch Blink SkShader clients to sk_sp

Skia is migrating its APIs to the new smart pointer type (sk_sp).  This is the
first phase, dealing with SkShader factories and setters.

1) convert Blink shader wrappers (Gradient, Pattern) to store sk_sp<SkShader>
   (instead of RefPtr<SkShader>).
2) use sk_sp factories (MakeFoo instead of CreateFoo)
3) call the sk_sp paint shader setters - setShader(sk_sp<SkShader>) instead of
   setShader(SkShader*).

BUG=skia:5077
R=reed@google.com,schenney@chromium.org,junov@chromium.org,senorblanco@chromi...
==========

[f(malita), 2016-03-09 19:07:06]

Description was changed from

==========
Switch Blink SkShader clients to sk_sp

Skia is migrating its APIs to the new smart pointer type (sk_sp).  This is the
first phase, dealing with SkShader factories and setters.

1) convert Blink shader wrappers (Gradient, Pattern) to store sk_sp<SkShader>
   (instead of RefPtr<SkShader>).
2) use sk_sp factories (MakeFoo instead of CreateFoo)
3) call the sk_sp paint shader setters - setShader(sk_sp<SkShader>) instead of
   setShader(SkShader*).

BUG=skia:5077
R=reed@google.com,schenney@chromium.org,junov@chromium.org,senorblanco@chromi...
==========

to

==========
Switch Blink SkShader clients to sk_sp

Skia is migrating its APIs to the new smart pointer type - sk_sp.  Among other
benefits, the new type/APIs help avoid atomic ref count churn thanks to
move semantics (ownership can now be transferred into Skia).

This is the first phase, dealing with SkShader factories and setters:

1) convert Blink shader wrappers (Gradient, Pattern) to store sk_sp<SkShader>
   (instead of RefPtr<SkShader>).
2) use sk_sp factories (MakeFoo instead of CreateFoo)
3) call the sk_sp paint shader setters - setShader(sk_sp<SkShader>) instead of
   setShader(SkShader*).

BUG=skia:5077
R=reed@google.com,schenney@chromium.org,junov@chromium.org,senorblanco@chromi...
==========

[f(malita), 2016-03-09 19:09:10]

Description was changed from

==========
Switch Blink SkShader clients to sk_sp

Skia is migrating its APIs to the new smart pointer type - sk_sp.  Among other
benefits, the new type/APIs help avoid atomic ref count churn thanks to
move semantics (ownership can now be transferred into Skia).

This is the first phase, dealing with SkShader factories and setters:

1) convert Blink shader wrappers (Gradient, Pattern) to store sk_sp<SkShader>
   (instead of RefPtr<SkShader>).
2) use sk_sp factories (MakeFoo instead of CreateFoo)
3) call the sk_sp paint shader setters - setShader(sk_sp<SkShader>) instead of
   setShader(SkShader*).

BUG=skia:5077
R=reed@google.com,schenney@chromium.org,junov@chromium.org,senorblanco@chromi...
==========

to

==========
Switch Blink SkShader clients to sk_sp

Skia is migrating its APIs to the new smart pointer type - sk_sp.  Among other
benefits, the new type/APIs help avoid atomic ref count churn thanks to
move semantics (ownership can now be transferred into Skia).

1) convert Blink shader wrappers (Gradient, Pattern) to store sk_sp<SkShader>
   (instead of RefPtr<SkShader>).
2) use sk_sp factories (MakeFoo instead of CreateFoo)
3) call the sk_sp paint shader setters - setShader(sk_sp<SkShader>) instead of
   setShader(SkShader*).

BUG=skia:5077
R=reed@google.com,schenney@chromium.org,junov@chromium.org,senorblanco@chromi...
==========

[f(malita), 2016-03-09 19:25:46]

fmalita@chromium.org changed reviewers:
+ junov@chromium.org, mtklein@google.com, reed@google.com,
schenney@chromium.org, senorblanco@chromium.org

[reed1, 2016-03-09 21:09:06]

https://codereview.chromium.org/1779833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp (right):

https://codereview.chromium.org/1779833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp:642:
paint.setShader(std::move(shader));
what to push this up 3 lines, and eliminate the named variable shader?

https://codereview.chromium.org/1779833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/Image.cpp (right):

https://codereview.chromium.org/1779833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/Image.cpp:192: return
sk_sp<SkShader>(image->newShader(SkShader::kRepeat_TileMode,
SkShader::kRepeat_TileMode, &shaderMatrix));
I will add SkImage::makeShader(...) NOW

https://codereview.chromium.org/1779833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/Image.cpp:254:
paint.setShader(std::move(shader));
move up 2 lines and eliminate named variable shader?

https://codereview.chromium.org/1779833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/PicturePattern.cpp (right):

https://codereview.chromium.org/1779833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/PicturePattern.cpp:21: ,
m_tilePicture(picture.leakRef())
Could we change the parameter type to avoid this scary leak call?

[f(malita), 2016-03-10 13:57:58]

https://codereview.chromium.org/1779833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp (right):

https://codereview.chromium.org/1779833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp:642:
paint.setShader(std::move(shader));
On 2016/03/09 21:09:06, reed1 wrote:
> what to push this up 3 lines, and eliminate the named variable shader?

Done.

https://codereview.chromium.org/1779833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/Image.cpp (right):

https://codereview.chromium.org/1779833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/Image.cpp:192: return
sk_sp<SkShader>(image->newShader(SkShader::kRepeat_TileMode,
SkShader::kRepeat_TileMode, &shaderMatrix));
On 2016/03/09 21:09:06, reed1 wrote:
> I will add SkImage::makeShader(...) NOW

Thanks, done.

https://codereview.chromium.org/1779833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/Image.cpp:254:
paint.setShader(std::move(shader));
On 2016/03/09 21:09:06, reed1 wrote:
> move up 2 lines and eliminate named variable shader?

Done.

https://codereview.chromium.org/1779833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/PicturePattern.cpp (right):

https://codereview.chromium.org/1779833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/PicturePattern.cpp:21: ,
m_tilePicture(picture.leakRef())
On 2016/03/09 21:09:06, reed1 wrote:
> Could we change the parameter type to avoid this scary leak call?

We'll have to chase it up all the way to the producer
(SkPictureBuilder::build()).  I'm planning to update that next, but would rather
handle it in a separate CL if we can live with leakPtr for a bit (note: there's
not much scary going on, it's the equivalent of release() on PassRefPtr).

If you think we should do that now, I can update but I suspect it'll fan-out
significantly.

[reed1, 2016-03-10 14:34:58]

definitely a fan of staged CLs, so no need to fan-out just to fix my question
about parameter type.

lgtm

[f(malita), 2016-03-10 20:11:21]

Earlier build errors are fixed, in case other reviewers were holding out.

[f(malita), 2016-03-11 14:16:05]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-03-11 14:16:06]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1779833002/#ps80001
(title: "build fix")

[commit-bot: I haz the power, 2016-03-11 14:16:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1779833002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1779833002/80001

[commit-bot: I haz the power, 2016-03-11 14:50:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 14:50:31]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[f(malita), 2016-03-11 16:46:03]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-03-11 16:46:03]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1779833002/#ps100001
(title: "rebase after MakePictureShader constness change")

[commit-bot: I haz the power, 2016-03-11 16:46:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1779833002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1779833002/100001

[commit-bot: I haz the power, 2016-03-11 17:42:14]

Description was changed from

==========
Switch Blink SkShader clients to sk_sp

Skia is migrating its APIs to the new smart pointer type - sk_sp.  Among other
benefits, the new type/APIs help avoid atomic ref count churn thanks to
move semantics (ownership can now be transferred into Skia).

1) convert Blink shader wrappers (Gradient, Pattern) to store sk_sp<SkShader>
   (instead of RefPtr<SkShader>).
2) use sk_sp factories (MakeFoo instead of CreateFoo)
3) call the sk_sp paint shader setters - setShader(sk_sp<SkShader>) instead of
   setShader(SkShader*).

BUG=skia:5077
R=reed@google.com,schenney@chromium.org,junov@chromium.org,senorblanco@chromi...
==========

to

==========
Switch Blink SkShader clients to sk_sp

Skia is migrating its APIs to the new smart pointer type - sk_sp.  Among other
benefits, the new type/APIs help avoid atomic ref count churn thanks to
move semantics (ownership can now be transferred into Skia).

1) convert Blink shader wrappers (Gradient, Pattern) to store sk_sp<SkShader>
   (instead of RefPtr<SkShader>).
2) use sk_sp factories (MakeFoo instead of CreateFoo)
3) call the sk_sp paint shader setters - setShader(sk_sp<SkShader>) instead of
   setShader(SkShader*).

BUG=skia:5077
R=reed@google.com,schenney@chromium.org,junov@chromium.org,senorblanco@chromi...
==========

[commit-bot: I haz the power, 2016-03-11 17:42:15]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-11 17:43:44]

Description was changed from

==========
Switch Blink SkShader clients to sk_sp

Skia is migrating its APIs to the new smart pointer type - sk_sp.  Among other
benefits, the new type/APIs help avoid atomic ref count churn thanks to
move semantics (ownership can now be transferred into Skia).

1) convert Blink shader wrappers (Gradient, Pattern) to store sk_sp<SkShader>
   (instead of RefPtr<SkShader>).
2) use sk_sp factories (MakeFoo instead of CreateFoo)
3) call the sk_sp paint shader setters - setShader(sk_sp<SkShader>) instead of
   setShader(SkShader*).

BUG=skia:5077
R=reed@google.com,schenney@chromium.org,junov@chromium.org,senorblanco@chromi...
==========

to

==========
Switch Blink SkShader clients to sk_sp

Skia is migrating its APIs to the new smart pointer type - sk_sp.  Among other
benefits, the new type/APIs help avoid atomic ref count churn thanks to
move semantics (ownership can now be transferred into Skia).

1) convert Blink shader wrappers (Gradient, Pattern) to store sk_sp<SkShader>
   (instead of RefPtr<SkShader>).
2) use sk_sp factories (MakeFoo instead of CreateFoo)
3) call the sk_sp paint shader setters - setShader(sk_sp<SkShader>) instead of
   setShader(SkShader*).

BUG=skia:5077
R=reed@google.com,schenney@chromium.org,junov@chromium.org,senorblanco@chromi...

Committed: https://crrev.com/12e75e492a66e801b464eefa9b61d1c5058c0c5c
Cr-Commit-Position: refs/heads/master@{#380664}
==========

[commit-bot: I haz the power, 2016-03-11 17:43:45]

Patchset 6 (id:??) landed as
https://crrev.com/12e75e492a66e801b464eefa9b61d1c5058c0c5c
Cr-Commit-Position: refs/heads/master@{#380664}

[f(malita), 2016-03-11 19:30:17]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1786183002/ by fmalita@chromium.org.

The reason for reverting is: While working on follow-up CLs it became clear that
using native sk_sps in Blink fans out massively.  A better approach may be to
introduce helpers for adopting sk_sp into PassRefPtr and releasing PassRefPtr
into sk_sp - then we only need to update the Skia/Blink API boundaries without
affecting Blink's internal APIs/types.

Reverting for now to evaluate the alternative approach..