Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1779803002: Revert of don't create zero length intervals (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
Reviewers:
f(malita), caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of don't create zero length intervals (patchset #1 id:1 of https://codereview.chromium.org/1766243004/ ) Reason for revert: This may, or may not, be blocking the DEPS roll with: svg/W3C-SVG-1.1/painting-stroke-04-t.svg - LayoutSVGPath {path} at (50,127) size 380x26 [stroke={[type=SOLID] [color=#000000] [stroke width=25.00] [dash offset=10.00] [dash array={10.00, 10.00}]}] [data="M 50 140 L 430 140"] + LayoutSVGPath {path} at (60,127) size 370x26 [stroke={[type=SOLID] [color=#000000] [stroke width=25.00] [dash offset=10.00] [dash array={10.00, 10.00}]}] [data="M 50 140 L 430 140"] Original issue's description: > don't create zero length intervals > > Dashing a pattern without zero-length intervals should > not create them if the end of the on interval coincides > with the beginning of the initial dash offset. > > R=reed@google.com > BUG=591993 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1766243004 > > Committed: https://skia.googlesource.com/skia/+/18bbd00190623fb6cdb119df4a118ac3c1aed52a TBR=reed@google.com,fmalita@chromium.org,caryclark@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=591993 Committed: https://skia.googlesource.com/skia/+/7f229ed827d1dc5897acfa87d84b642ce34b678f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M gm/bug530095.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M src/utils/SkDashPath.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of don't create zero length intervals
4 years, 9 months ago (2016-03-09 16:37:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779803002/1
4 years, 9 months ago (2016-03-09 16:37:13 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 16:37:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7f229ed827d1dc5897acfa87d84b642ce34b678f

Powered by Google App Engine
This is Rietveld 408576698