Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1779793003: Remove host_desktop_type() from browser.h (Closed)

Created:
4 years, 9 months ago by scottmg
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, jam, sadrul, tfarina, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-43
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove host_desktop_type() from browser.h R=sky@chromium.org BUG=558054 Committed: https://crrev.com/9616ceea5c37912b01fcef1f67eb3f9871b3f08a Cr-Commit-Position: refs/heads/master@{#381476}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : . #

Patch Set 4 : cros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -68 lines) Patch
M chrome/browser/platform_util_chromeos.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_status_monitor.cc View 3 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_list.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_navigator_params.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_navigator_params.cc View 6 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/app_menu_model.cc View 1 2 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
scottmg
4 years, 9 months ago (2016-03-15 23:32:27 UTC) #1
sky
https://codereview.chromium.org/1779793003/diff/20001/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc File chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc (right): https://codereview.chromium.org/1779793003/diff/20001/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc#newcode125 chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc:125: #if !defined(USE_ASH) Why are we compiling this file if ...
4 years, 9 months ago (2016-03-15 23:52:56 UTC) #2
scottmg
https://codereview.chromium.org/1779793003/diff/20001/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc File chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc (right): https://codereview.chromium.org/1779793003/diff/20001/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc#newcode125 chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc:125: #if !defined(USE_ASH) On 2016/03/15 23:52:56, sky wrote: > Why ...
4 years, 9 months ago (2016-03-16 01:21:48 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779793003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779793003/40001
4 years, 9 months ago (2016-03-16 01:22:16 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/157809)
4 years, 9 months ago (2016-03-16 01:35:24 UTC) #7
sky
LGTM
4 years, 9 months ago (2016-03-16 15:33:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779793003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779793003/60001
4 years, 9 months ago (2016-03-16 16:10:37 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-16 16:58:58 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 17:02:04 UTC) #13
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/9616ceea5c37912b01fcef1f67eb3f9871b3f08a
Cr-Commit-Position: refs/heads/master@{#381476}

Powered by Google App Engine
This is Rietveld 408576698