Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 1779743004: MacViews: Fix MenuRunnerTest.NonLatinMnemonic (Closed)

Created:
4 years, 9 months ago by tapted
Modified:
4 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tfarina, tdresser+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Fix MenuRunnerTest.NonLatinMnemonic The test NSEvent synthesizer didn't handle unicode characters. Add support for this by feeding through the DomKey from "character" ui::KeyEvents. BUG=592890 Committed: https://crrev.com/e8acb685ae8b680ca50b611ce5cd0dc0fc2506c6 Cr-Commit-Position: refs/heads/master@{#380361}

Patch Set 1 #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M ui/events/test/cocoa_test_event_utils.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/events/test/cocoa_test_event_utils.mm View 1 2 chunks +7 lines, -1 line 0 comments Download
M ui/views/test/event_generator_delegate_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779743004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779743004/20001
4 years, 9 months ago (2016-03-10 04:24:05 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-10 05:40:34 UTC) #4
tapted
Hi Avi, please take a look
4 years, 9 months ago (2016-03-10 06:13:25 UTC) #7
Avi (use Gerrit)
lgtm
4 years, 9 months ago (2016-03-10 06:21:53 UTC) #8
tapted
wow you're up late - thanks!
4 years, 9 months ago (2016-03-10 06:22:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779743004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779743004/20001
4 years, 9 months ago (2016-03-10 06:22:58 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-10 06:29:34 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e8acb685ae8b680ca50b611ce5cd0dc0fc2506c6 Cr-Commit-Position: refs/heads/master@{#380361}
4 years, 9 months ago (2016-03-10 06:34:05 UTC) #15
Avi (use Gerrit)
4 years, 9 months ago (2016-03-10 19:31:17 UTC) #16
Message was sent while issue was closed.
On 2016/03/10 06:22:35, tapted wrote:
> wow you're up late - thanks!

Was watching the AlphaGo match.

Powered by Google App Engine
This is Rietveld 408576698