Switch SkPictureImageFilter over to new onFilterImage interface

Switch SkPictureImageFilter over to new onFilterImage interface

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1779743002

TBR=bsalomon@google.com

Committed: https://skia.googlesource.com/skia/+/fef28606d2c51be627be3a656581882e31945c03

[robertphillips, 2016-03-09 13:16:57]

Description was changed from

==========
Switch SkPictureImageFilter over to new onFilterImage interface
==========

to

==========
Switch SkPictureImageFilter over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-09 13:20:51]

Description was changed from

==========
Switch SkPictureImageFilter over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch SkPictureImageFilter over to new onFilterImage interface

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

TBR=bsalomon@google.com
==========

[robertphillips, 2016-03-09 13:20:51]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com, senorblanco@chromium.org, senorblanco@google.com

[Stephen White, 2016-03-22 19:58:49]

https://codereview.chromium.org/1779743002/diff/60001/src/effects/SkPictureIm...
File src/effects/SkPictureImageFilter.cpp (right):

https://codereview.chromium.org/1779743002/diff/60001/src/effects/SkPictureIm...
src/effects/SkPictureImageFilter.cpp:104: return nullptr;
I think this will change the behaviour from continuing processing with a
transparent black image to aborting filter processing.

e.g.,

SkPictureImageFilter -> SkColorFilterImageFilter

where the color filter affects transparent black.

I think we need some way to signal the DAG to continue, probably some kind of
"canonical transparent image" to return.

(OTOH, it looks like the above bounds intersection should probably also be
returning that canonical transparent image).

[robertphillips, 2016-03-25 16:53:18]

https://codereview.chromium.org/1779743002/diff/60001/src/effects/SkPictureIm...
File src/effects/SkPictureImageFilter.cpp (right):

https://codereview.chromium.org/1779743002/diff/60001/src/effects/SkPictureIm...
src/effects/SkPictureImageFilter.cpp:104: return nullptr;
I have updated the two above calls sites to duplicate the prior behavior (i.e.,
returning the unmodified source).

[Stephen White, 2016-04-04 15:52:12]

LGTM

[robertphillips, 2016-04-11 17:17:13]

Local layout test runs indicate that this shouldn't alter the layout test
results.

[robertphillips, 2016-04-11 17:17:24]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-11 17:17:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1779743002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1779743002/140001

[commit-bot: I haz the power, 2016-04-11 17:32:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-11 17:32:37]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-11 18:07:24]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-04-11 18:07:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
senorblanco@chromium.org
Link to the patchset: https://codereview.chromium.org/1779743002/#ps140001
(title: "update to ToT")

[commit-bot: I haz the power, 2016-04-11 18:07:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1779743002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1779743002/140001

[commit-bot: I haz the power, 2016-04-11 18:08:55]

Description was changed from

==========
Switch SkPictureImageFilter over to new onFilterImage interface

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

TBR=bsalomon@google.com
==========

to

==========
Switch SkPictureImageFilter over to new onFilterImage interface

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/fef28606d2c51be627be3a656581882e31945c03
==========

[commit-bot: I haz the power, 2016-04-11 18:08:55]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/fef28606d2c51be627be3a656581882e31945c03