Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: net/spdy/spdy_session_pool.cc

Issue 1779733003: Fix bug in net::RequestPriority -> HTTP/2 dependency conversion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporate Bence's detailed comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_session_pool.cc
diff --git a/net/spdy/spdy_session_pool.cc b/net/spdy/spdy_session_pool.cc
index db8ddb153b1f16adc25dcbd84ce04b9efd989381..7f46c328db99052561142b9ab3b810ee38ebdb80 100644
--- a/net/spdy/spdy_session_pool.cc
+++ b/net/spdy/spdy_session_pool.cc
@@ -35,6 +35,7 @@ SpdySessionPool::SpdySessionPool(
const base::WeakPtr<HttpServerProperties>& http_server_properties,
TransportSecurityState* transport_security_state,
bool enable_ping_based_connection_checking,
+ bool enable_priority_dependencies,
NextProto default_protocol,
size_t session_max_recv_window_size,
size_t stream_max_recv_window_size,
@@ -48,6 +49,7 @@ SpdySessionPool::SpdySessionPool(
enable_sending_initial_data_(true),
enable_ping_based_connection_checking_(
enable_ping_based_connection_checking),
+ enable_priority_dependencies_(enable_priority_dependencies),
// TODO(akalin): Force callers to have a valid value of
// |default_protocol_|.
default_protocol_((default_protocol == kProtoUnknown) ? kProtoSPDY31
@@ -94,9 +96,10 @@ base::WeakPtr<SpdySession> SpdySessionPool::CreateAvailableSessionFromSocket(
scoped_ptr<SpdySession> new_session(new SpdySession(
key, http_server_properties_, transport_security_state_,
verify_domain_authentication_, enable_sending_initial_data_,
- enable_ping_based_connection_checking_, default_protocol_,
- session_max_recv_window_size_, stream_max_recv_window_size_, time_func_,
- proxy_delegate_, net_log.net_log()));
+ enable_ping_based_connection_checking_, enable_priority_dependencies_,
+ default_protocol_, session_max_recv_window_size_,
+ stream_max_recv_window_size_, time_func_, proxy_delegate_,
+ net_log.net_log()));
new_session->InitializeWithSocket(std::move(connection), this, is_secure,
certificate_error_code);

Powered by Google App Engine
This is Rietveld 408576698