Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2147)

Unified Diff: net/spdy/spdy_network_transaction_unittest.cc

Issue 1779733003: Fix bug in net::RequestPriority -> HTTP/2 dependency conversion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporate Bence's detailed comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_network_transaction_unittest.cc
diff --git a/net/spdy/spdy_network_transaction_unittest.cc b/net/spdy/spdy_network_transaction_unittest.cc
index c563868072bff28c6050ac9c2fe61a70ffbae5cc..fff29ba480f4fc3f23cc6501f78859ac42a73e18 100644
--- a/net/spdy/spdy_network_transaction_unittest.cc
+++ b/net/spdy/spdy_network_transaction_unittest.cc
@@ -114,6 +114,8 @@ void UpdateSpdySessionDependencies(SpdyNetworkTransactionTestParams test_params,
"www.example.org", 443),
1.0, expiration);
}
+ session_deps->enable_priority_dependencies =
+ test_params.priority_to_dependency;
}
scoped_ptr<SpdySessionDependencies> CreateSpdySessionDependencies(
@@ -140,8 +142,6 @@ class SpdyNetworkTransactionTest
protected:
SpdyNetworkTransactionTest()
: spdy_util_(GetParam().protocol, GetParam().priority_to_dependency) {
- SpdySession::SetPriorityDependencyDefaultForTesting(
- GetParam().priority_to_dependency);
spdy_util_.set_default_url(GURL(GetDefaultUrl()));
}
@@ -150,7 +150,6 @@ class SpdyNetworkTransactionTest
// destruction.
upload_data_stream_.reset();
base::RunLoop().RunUntilIdle();
- SpdySession::SetPriorityDependencyDefaultForTesting(false);
}
void SetUp() override {

Powered by Google App Engine
This is Rietveld 408576698