net/http/http_network_transaction_unittest.cc - Issue 1779733003: Fix bug in net::RequestPriority -> HTTP/2 dependency conversion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 1779733003: Fix bug in net::RequestPriority -> HTTP/2 dependency conversion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporate Bence's detailed comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_network_transaction_unittest.cc

diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc

index bc7f7b37dfbf3d0f33dac274a581e2aad2f2e157..7961143fc4e9437b1c24d91c02f6d9369c01d74b 100644

--- a/net/http/http_network_transaction_unittest.cc

+++ b/net/http/http_network_transaction_unittest.cc

@@ -271,7 +271,6 @@ class HttpNetworkTransactionTest

HttpNetworkSession::NORMAL_SOCKET_POOL, old_max_pool_sockets_);

ClientSocketPoolManager::set_max_sockets_per_group(

HttpNetworkSession::NORMAL_SOCKET_POOL, old_max_group_sockets_);

- SpdySession::SetPriorityDependencyDefaultForTesting(false);

}

protected:

@@ -282,8 +281,7 @@ class HttpNetworkTransactionTest

HttpNetworkSession::NORMAL_SOCKET_POOL)),

old_max_pool_sockets_(ClientSocketPoolManager::max_sockets_per_pool(

HttpNetworkSession::NORMAL_SOCKET_POOL)) {

- SpdySession::SetPriorityDependencyDefaultForTesting(

- GetDependenciesFromPriority());

+ session_deps_.enable_priority_dependencies = GetDependenciesFromPriority();

}

struct SimpleGetHelperResult {

« no previous file with comments | « net/http/http_network_session.cc ('k') | net/http/http_proxy_client_socket_pool_unittest.cc » ('j') | net/spdy/http2_priority_dependencies.cc » ('J')