Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: net/spdy/spdy_session_unittest.cc

Issue 1779733003: Fix bug in net::RequestPriority -> HTTP/2 dependency conversion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_session_unittest.cc
diff --git a/net/spdy/spdy_session_unittest.cc b/net/spdy/spdy_session_unittest.cc
index eb7ded1796ff387484d830a0ce9e70fa19bf8d04..a437db250db5d1f82bb5442aa33ce836f8003c92 100644
--- a/net/spdy/spdy_session_unittest.cc
+++ b/net/spdy/spdy_session_unittest.cc
@@ -139,8 +139,9 @@ class SpdySessionTest : public PlatformTest,
key_(test_host_port_pair_,
ProxyServer::Direct(),
PRIVACY_MODE_DISABLED) {
- SpdySession::SetPriorityDependencyDefaultForTesting(
- GetDependenciesFromPriority());
+ old_dependency_default_ =
+ Http2PriorityDependencies::SetEnabledDefaultForTesting(
+ GetDependenciesFromPriority());
}
virtual ~SpdySessionTest() {
@@ -150,7 +151,8 @@ class SpdySessionTest : public PlatformTest,
HttpNetworkSession::NORMAL_SOCKET_POOL, old_max_pool_sockets_);
ClientSocketPoolManager::set_max_sockets_per_group(
HttpNetworkSession::NORMAL_SOCKET_POOL, old_max_group_sockets_);
- SpdySession::SetPriorityDependencyDefaultForTesting(false);
+ Http2PriorityDependencies::SetEnabledDefaultForTesting(
+ old_dependency_default_);
}
void SetUp() override {
@@ -215,6 +217,7 @@ class SpdySessionTest : public PlatformTest,
HostPortPair test_host_port_pair_;
SpdySessionKey key_;
BoundTestNetLog log_;
+ bool old_dependency_default_;
};
INSTANTIATE_TEST_CASE_P(ProtoPlusDepend,

Powered by Google App Engine
This is Rietveld 408576698