Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2002)

Unified Diff: net/spdy/spdy_session.h

Issue 1779733003: Fix bug in net::RequestPriority -> HTTP/2 dependency conversion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_session.h
diff --git a/net/spdy/spdy_session.h b/net/spdy/spdy_session.h
index 8e3ea1b4a5fd4259f09adf828b3d2c980f72a527..49f3b709ef0b29f6b6a0e97b9e0cbc938c0fbe8e 100644
--- a/net/spdy/spdy_session.h
+++ b/net/spdy/spdy_session.h
@@ -31,6 +31,7 @@
#include "net/socket/ssl_client_socket.h"
#include "net/socket/stream_socket.h"
#include "net/spdy/buffered_spdy_framer.h"
+#include "net/spdy/http2_priority_dependencies.h"
#include "net/spdy/spdy_buffer.h"
#include "net/spdy/spdy_framer.h"
#include "net/spdy/spdy_header_block.h"
@@ -959,10 +960,6 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
bool check_ping_status_pending() const { return check_ping_status_pending_; }
- // Set whether priority->dependency conversion is enabled
- // by default for all future SpdySessions.
- static void SetPriorityDependencyDefaultForTesting(bool enable);
-
// Whether Do{Read,Write}Loop() is in the call stack. Useful for
// making sure we don't destroy ourselves prematurely in that case.
bool in_io_loop_;
@@ -1009,14 +1006,6 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
// them?
ActiveStreamMap active_streams_;
- // Per-priority map from stream id to all active streams. This map will
- // contain the same set of streams as |active_streams_|. It is used for
- // setting dependencies to match incoming requests RequestPriority.
- //
- // |active_streams_by_priority_| does *not* own its SpdyStream objects.
- std::map<SpdyStreamId, SpdyStream*>
- active_streams_by_priority_[NUM_PRIORITIES];
-
// (Bijective) map from the URL to the ID of the streams that have
// already started to be pushed by the server, but do not have
// consumers yet. Contains a subset of |active_streams_|.
@@ -1192,9 +1181,7 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
TimeFunc time_func_;
- // Should priority-based dependency information be sent in stream header
- // frames.
- bool send_priority_dependency_;
+ Http2PriorityDependencies priority_dependency_state_;
// Used for posting asynchronous IO tasks. We use this even though
// SpdySession is refcounted because we don't need to keep the SpdySession

Powered by Google App Engine
This is Rietveld 408576698