Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 1779733003: Fix bug in net::RequestPriority -> HTTP/2 dependency conversion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index bc7f7b37dfbf3d0f33dac274a581e2aad2f2e157..dedef0b53d39a0dc6d73e798e23d7e811a8739cf 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -271,7 +271,8 @@ class HttpNetworkTransactionTest
HttpNetworkSession::NORMAL_SOCKET_POOL, old_max_pool_sockets_);
ClientSocketPoolManager::set_max_sockets_per_group(
HttpNetworkSession::NORMAL_SOCKET_POOL, old_max_group_sockets_);
- SpdySession::SetPriorityDependencyDefaultForTesting(false);
+ Http2PriorityDependencies::SetEnabledDefaultForTesting(
+ old_dependency_default_);
}
protected:
@@ -282,8 +283,9 @@ class HttpNetworkTransactionTest
HttpNetworkSession::NORMAL_SOCKET_POOL)),
old_max_pool_sockets_(ClientSocketPoolManager::max_sockets_per_pool(
HttpNetworkSession::NORMAL_SOCKET_POOL)) {
- SpdySession::SetPriorityDependencyDefaultForTesting(
- GetDependenciesFromPriority());
+ old_dependency_default_ =
+ Http2PriorityDependencies::SetEnabledDefaultForTesting(
+ GetDependenciesFromPriority());
}
struct SimpleGetHelperResult {
@@ -476,6 +478,9 @@ class HttpNetworkTransactionTest
// them once each test has been run.
int old_max_group_sockets_;
int old_max_pool_sockets_;
+
+ // Pre-test default for priority dependencies.
+ bool old_dependency_default_;
};
INSTANTIATE_TEST_CASE_P(ProtoPlusDepend,
« no previous file with comments | « no previous file | net/http/http_proxy_client_socket_pool_unittest.cc » ('j') | net/spdy/http2_priority_dependencies.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698