Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: net/spdy/http2_priority_dependencies.cc

Issue 1779733003: Fix bug in net::RequestPriority -> HTTP/2 dependency conversion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make bi-directional stream unittests enable priority->dependency setting. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "net/spdy/http2_priority_dependencies.h"
6
7 namespace net {
8
9 Http2PriorityDependencies::Http2PriorityDependencies() {}
10
11 Http2PriorityDependencies::~Http2PriorityDependencies() {}
12
13 void Http2PriorityDependencies::OnStreamSynSent(
14 SpdyStreamId id,
15 SpdyPriority priority,
16 SpdyStreamId* dependent_stream_id,
17 bool* exclusive) {
18 DCHECK(entry_by_stream_id_.find(id) == entry_by_stream_id_.end());
19
20 *dependent_stream_id = 0ul;
21 *exclusive = true;
22
23 // Find the next highest entry in total order.
24 for (int i = priority; i >= kV3HighestPriority; --i) {
25 if (!id_priority_lists_[i].empty()) {
26 *dependent_stream_id = id_priority_lists_[i].back().first;
27 break;
28 }
29 }
30
31 id_priority_lists_[priority].push_back(std::make_pair(id, priority));
32 IdList::iterator it = id_priority_lists_[priority].end();
33 --it;
34 entry_by_stream_id_[id] = it;
35 }
36
37 void Http2PriorityDependencies::OnStreamDestruction(SpdyStreamId id) {
38 EntryMap::iterator emit = entry_by_stream_id_.find(id);
39
40 // This routine may be called without a matching call to
41 // OnStreamSynSent above, in the case of server push. In that case,
42 // it's a no-op.
43 if (emit == entry_by_stream_id_.end())
44 return;
45
46 IdList::iterator it = emit->second;
47 id_priority_lists_[it->second].erase(it);
48 entry_by_stream_id_.erase(emit);
49 }
50
51 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/http2_priority_dependencies.h ('k') | net/spdy/http2_priority_dependencies_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698