Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Side by Side Diff: net/http/http_proxy_client_socket_pool_unittest.cc

Issue 1779733003: Fix bug in net::RequestPriority -> HTTP/2 dependency conversion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_proxy_client_socket_pool.h" 5 #include "net/http/http_proxy_client_socket_pool.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 NULL, 86 NULL,
87 session_deps_.ssl_config_service.get(), 87 session_deps_.ssl_config_service.get(),
88 BoundNetLog().net_log()), 88 BoundNetLog().net_log()),
89 session_(CreateNetworkSession()), 89 session_(CreateNetworkSession()),
90 spdy_util_(GetParam().protocol, GetParam().priority_to_dependency), 90 spdy_util_(GetParam().protocol, GetParam().priority_to_dependency),
91 pool_(kMaxSockets, 91 pool_(kMaxSockets,
92 kMaxSocketsPerGroup, 92 kMaxSocketsPerGroup,
93 &transport_socket_pool_, 93 &transport_socket_pool_,
94 &ssl_socket_pool_, 94 &ssl_socket_pool_,
95 NULL) { 95 NULL) {
96 SpdySession::SetPriorityDependencyDefaultForTesting( 96 old_dependency_default_ =
97 GetParam().priority_to_dependency); 97 Http2PriorityDependencies::SetEnabledDefaultForTesting(
98 GetParam().priority_to_dependency);
98 } 99 }
99 100
100 virtual ~HttpProxyClientSocketPoolTest() { 101 virtual ~HttpProxyClientSocketPoolTest() {
101 SpdySession::SetPriorityDependencyDefaultForTesting(false); 102 Http2PriorityDependencies::SetEnabledDefaultForTesting(
103 old_dependency_default_);
102 } 104 }
103 105
104 void AddAuthToCache() { 106 void AddAuthToCache() {
105 const base::string16 kFoo(base::ASCIIToUTF16("foo")); 107 const base::string16 kFoo(base::ASCIIToUTF16("foo"));
106 const base::string16 kBar(base::ASCIIToUTF16("bar")); 108 const base::string16 kBar(base::ASCIIToUTF16("bar"));
107 GURL proxy_url(GetParam().proxy_type == HTTP ? 109 GURL proxy_url(GetParam().proxy_type == HTTP ?
108 (std::string("http://") + kHttpProxyHost) : 110 (std::string("http://") + kHttpProxyHost) :
109 (std::string("https://") + kHttpsProxyHost)); 111 (std::string("https://") + kHttpsProxyHost));
110 session_->http_auth_cache()->Add(proxy_url, 112 session_->http_auth_cache()->Add(proxy_url,
111 "MyRealm1", 113 "MyRealm1",
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 private: 216 private:
215 SpdySessionDependencies session_deps_; 217 SpdySessionDependencies session_deps_;
216 218
217 MockTransportClientSocketPool transport_socket_pool_; 219 MockTransportClientSocketPool transport_socket_pool_;
218 MockHostResolver host_resolver_; 220 MockHostResolver host_resolver_;
219 scoped_ptr<CertVerifier> cert_verifier_; 221 scoped_ptr<CertVerifier> cert_verifier_;
220 SSLClientSocketPool ssl_socket_pool_; 222 SSLClientSocketPool ssl_socket_pool_;
221 223
222 const scoped_ptr<HttpNetworkSession> session_; 224 const scoped_ptr<HttpNetworkSession> session_;
223 225
226 bool old_dependency_default_;
227
224 protected: 228 protected:
225 SpdyTestUtil spdy_util_; 229 SpdyTestUtil spdy_util_;
226 scoped_ptr<SSLSocketDataProvider> ssl_data_; 230 scoped_ptr<SSLSocketDataProvider> ssl_data_;
227 scoped_ptr<SequencedSocketData> data_; 231 scoped_ptr<SequencedSocketData> data_;
228 HttpProxyClientSocketPool pool_; 232 HttpProxyClientSocketPool pool_;
229 ClientSocketHandle handle_; 233 ClientSocketHandle handle_;
230 TestCompletionCallback callback_; 234 TestCompletionCallback callback_;
231 }; 235 };
232 236
233 //----------------------------------------------------------------------------- 237 //-----------------------------------------------------------------------------
(...skipping 507 matching lines...) Expand 10 before | Expand all | Expand 10 after
741 // Make sure Location header was included and correct. 745 // Make sure Location header was included and correct.
742 std::string location; 746 std::string location;
743 EXPECT_TRUE(headers->IsRedirect(&location)); 747 EXPECT_TRUE(headers->IsRedirect(&location));
744 EXPECT_EQ(location, redirectTarget); 748 EXPECT_EQ(location, redirectTarget);
745 } 749 }
746 } 750 }
747 751
748 // It would be nice to also test the timeouts in HttpProxyClientSocketPool. 752 // It would be nice to also test the timeouts in HttpProxyClientSocketPool.
749 753
750 } // namespace net 754 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698