Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1779733002: Move code to register Oilpan's interruptor to V8Initializer::initialize (Closed)

Created:
4 years, 9 months ago by haraken
Modified:
4 years, 9 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move code to register Oilpan's interruptor to V8Initializer::initialize The code is about V8, so it should be in V8Initializer::initialize. BUG=593269 Committed: https://crrev.com/2628e5ca3e670725639f6e8def4287c276513f6a Cr-Commit-Position: refs/heads/master@{#380133}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebKit.cpp View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
haraken
PTAL
4 years, 9 months ago (2016-03-09 12:45:32 UTC) #2
sof
lgtm, nice.
4 years, 9 months ago (2016-03-09 12:50:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1779733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1779733002/1
4 years, 9 months ago (2016-03-09 12:52:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 14:07:31 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 14:08:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2628e5ca3e670725639f6e8def4287c276513f6a
Cr-Commit-Position: refs/heads/master@{#380133}

Powered by Google App Engine
This is Rietveld 408576698