Issue 1779723002: dart2js cps: Inline constructor bodies that are only called once.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1779723002: dart2js cps: Inline constructor bodies that are only called once. (Closed)

Created:
4 years, 9 months ago by asgerf

Modified:
4 years, 9 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js cps: Inline constructor bodies that are only called once. ConstructorBodyElements do not exist in the type inference graph, so we can't rely on it to tell us if such a method has a single call site. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/cb46f224f6468c4afe40ccb7a94cf1568eb1ba88

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/inline.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	tests/compiler/dart2js/cps_ir/expected/constructor_9.js	View	1	1 chunk	+11 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

asgerf

4 years, 9 months ago (2016-03-09 13:00:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
cb46f224f6468c4afe40ccb7a94cf1568eb1ba88 (presubmit successful).