Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: src/compiler/x87/instruction-selector-x87.cc

Issue 1779713009: Implement optional turbofan UnalignedLoad and UnalignedStore operators (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix failures in cctest/test-run-wasm-64/Run_Wasm_LoadStoreI64_sx due to missing implementation of U… Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/adapters.h" 5 #include "src/base/adapters.h"
6 #include "src/compiler/instruction-selector-impl.h" 6 #include "src/compiler/instruction-selector-impl.h"
7 #include "src/compiler/node-matchers.h" 7 #include "src/compiler/node-matchers.h"
8 #include "src/compiler/node-properties.h" 8 #include "src/compiler/node-properties.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 AddressingMode addressing_mode = 257 AddressingMode addressing_mode =
258 g.GetEffectiveAddressMemoryOperand(node, inputs, &input_count); 258 g.GetEffectiveAddressMemoryOperand(node, inputs, &input_count);
259 InstructionCode code = 259 InstructionCode code =
260 opcode | AddressingModeField::encode(addressing_mode); 260 opcode | AddressingModeField::encode(addressing_mode);
261 inputs[input_count++] = val; 261 inputs[input_count++] = val;
262 Emit(code, 0, static_cast<InstructionOperand*>(nullptr), input_count, 262 Emit(code, 0, static_cast<InstructionOperand*>(nullptr), input_count,
263 inputs); 263 inputs);
264 } 264 }
265 } 265 }
266 266
267 // Architecture supports unaliged access, therefore VisitLoad is used instead
268 void InstructionSelector::VisitUnalignedLoad(Node* node) { UNREACHABLE(); }
269
270 // Architecture supports unaliged access, therefore VisitStore is used instead
271 void InstructionSelector::VisitUnalignedStore(Node* node) { UNREACHABLE(); }
267 272
268 void InstructionSelector::VisitCheckedLoad(Node* node) { 273 void InstructionSelector::VisitCheckedLoad(Node* node) {
269 CheckedLoadRepresentation load_rep = CheckedLoadRepresentationOf(node->op()); 274 CheckedLoadRepresentation load_rep = CheckedLoadRepresentationOf(node->op());
270 X87OperandGenerator g(this); 275 X87OperandGenerator g(this);
271 Node* const buffer = node->InputAt(0); 276 Node* const buffer = node->InputAt(0);
272 Node* const offset = node->InputAt(1); 277 Node* const offset = node->InputAt(1);
273 Node* const length = node->InputAt(2); 278 Node* const length = node->InputAt(2);
274 ArchOpcode opcode = kArchNop; 279 ArchOpcode opcode = kArchNop;
275 switch (load_rep.representation()) { 280 switch (load_rep.representation()) {
276 case MachineRepresentation::kWord8: 281 case MachineRepresentation::kWord8:
(...skipping 1286 matching lines...) Expand 10 before | Expand all | Expand 10 after
1563 MachineOperatorBuilder::kFloat32RoundTruncate | 1568 MachineOperatorBuilder::kFloat32RoundTruncate |
1564 MachineOperatorBuilder::kFloat64RoundTruncate | 1569 MachineOperatorBuilder::kFloat64RoundTruncate |
1565 MachineOperatorBuilder::kFloat32RoundTiesEven | 1570 MachineOperatorBuilder::kFloat32RoundTiesEven |
1566 MachineOperatorBuilder::kFloat64RoundTiesEven; 1571 MachineOperatorBuilder::kFloat64RoundTiesEven;
1567 return flags; 1572 return flags;
1568 } 1573 }
1569 1574
1570 } // namespace compiler 1575 } // namespace compiler
1571 } // namespace internal 1576 } // namespace internal
1572 } // namespace v8 1577 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698